[HOLD for payment 2023-06-05] [$1000] No hover effect on reactions list

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. open group > send message > react with 2 or more accounts
2. hover over the members in list

Expected results:

hover effect should be there like other similar components in the app (like start a call menu). Additionally, open the user detail page when the user clicks on a user profile (more details here).

Actual results:

no hover effect

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.13.
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bandicam.2023-05-13.16-31-29-472.mp4

Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683975718761019

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c0b60ca5f036fe39
• Upwork Job ID: 1658661267676348416
• Last Price Increase: 2023-05-17

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[PrashantMangukiya]

Proposal

Posting proposal early as per new guidelines

Please re-state the problem that we are trying to solve in this issue.

No hover effect on reactions list

What is the root cause of that problem?

Reaction list render via OptionRow as shown below:

App/src/pages/home/report/ReactionList/BaseReactionList.js

Lines 43 to 63 in 148517a

	const renderItem = ({item}) => (
	<OptionRow
	item={item}
	boldStyle
	isDisabled
	style={{maxWidth: variables.mobileResponsiveWidthBreakpoint}}
	option={{
	text: Str.removeSMSDomain(item.displayName),
	alternateText: Str.removeSMSDomain(item.login),
	participantsList: [item],
	icons: [
	{
	source: ReportUtils.getAvatar(item.avatar, item.login),
	name: item.login,
	type: CONST.ICON_TYPE_AVATAR,
	},
	],
	keyForList: item.login,
	}}
	/>
	);

We can see hoverStyle not passed to OptionRow. So it will not show hover effect, this is the root cause of the problem.

What changes do you think we should make in order to solve the problem?

We have to pass hoverStyle prop to OptionRow component as shown code below:

const renderItem = ({item}) => (
    <OptionRow
        hoverStyle={styles.hoveredComponentBG}   // ** ADD THIS ***
        ...
    />
);

This will solve the issue and show hover effect as shown in result.

What alternative solutions did you explore? (Optional)

None

Result

Web.mov

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• No hover effect on reactions list

What is the root cause of that problem?

• The root cause is we using <OptionRow> with isDisable props that make it hover stated disable as well

What changes do you think we should make in order to solve the problem?

• We have 2 option to solve this problem

Solution 1

• In order to show hover effect we can remove isDisable props and add hoverStyle={styles.hoveredComponentBG} inside BaseReactionList.js

• We also need to add blank onSelectRow() event (cursor disable style optionally)

• Also we can create new Props to show hovers state on disabled onSelectRow()

Solution 2

• While enabling the onSelectRow() We can open drawer with user details (drawer) onPress(onSelectRow) of particular user this is specially useful on larger group chat we can directly see user profile detail on press

• In order to open user detail drawer we need to add Navigation.navigate(ROUTES.getDetailsRoute(email)) to onSelectRow

What alternative solutions did you explore? (Optional)

• None

Result for Solution 2

Untitled.mp4

Result for Solution 1

onlyHovered.mov

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[JmillsExpensify]

Hmm, this "bug" is debatable vs a new feature, though I'm triaging it to keep the issue moving while I'm at a conference.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c0b60ca5f036fe39

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.