Skip to content

[HOLD for payment 2024-03-20] [$500] Users can enter more characters than the specified limit #18891

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to the Settings > Profile >Display name
  2. Enter a name exceeding the character limit and continue typing on first name field

Expected Result:

Users should not enter more than the specified limit of characters

Actual Result:

Users can enter more characters than the specified limit in the First name and Last name fields and removed extra characters after pressing space button

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.13.4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

20230513010402.mp4
az_recorder_20230513_123426.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683923406716779

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a433a674a93990d0
  • Upwork Job ID: 1760227161153392640
  • Last Price Increase: 2024-02-21
  • Automatic offers:
    • aimane-chnaif | Reviewer | 0
    • dhairyasenjaliya | Contributor | 0

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 13, 2023
  2. melvin-bot commented on May 13, 2023

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 13, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. dhairyasenjaliya commented on May 13, 2023

    @dhairyasenjaliya
    Contributor

    this can be hold in favour of #18647 still we need to decide limit

  5. changed the title [-]Users can enter more characters than the specified limit[/-] [+][HOLD on #18647] Users can enter more characters than the specified limit[/+] on May 15, 2023
  6. laurenreidexpensify commented on May 16, 2023

    @laurenreidexpensify
    Contributor

    Making this a weekly

  7. laurenreidexpensify commented on May 22, 2023

    @laurenreidexpensify
    Contributor

    No update on #18647 so still on hold

  8. laurenreidexpensify commented on May 31, 2023

    @laurenreidexpensify
    Contributor

    No update on #18647 so remains on hold again this week

  9. 113 remaining items

  10. melvin-bot commented on Mar 13, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Mar 13, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-20. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Mar 13, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
    • [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@aimane-chnaif] Determine if we should create a regression test for this bug.
    • [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. laurenreidexpensify commented on Mar 25, 2024

    @laurenreidexpensify
    Contributor

    @ayazhussain79 let's handle your payment in #38941

    @aimane-chnaif pls complete checklist above thanks

  14. aimane-chnaif commented on Mar 25, 2024

    @aimane-chnaif
    Contributor

    This is more like feature request.

    Regression Test Proposal

    1. Go to Settings > Profile > Display name
    2. Enter more then 100 characters on first / last name fields
    3. Verify that characters can be entered endlessly
    4. Click on Save button
    5. Verify that character limit exceeded error shows
  15. luacmartins commented on Mar 25, 2024

    @luacmartins
    Contributor

    I don't think that we need to add this case. It's a bit extreme that people would enter more than 100 chars into a name field, so I don't think we need to be explicitly testing this.

  16. aimane-chnaif commented on Mar 25, 2024

    @aimane-chnaif
    Contributor

    Thanks, we can just close this then after all payment set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions