You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-03-20] [$500] Users can enter more characters than the specified limit #18891
Enter a name exceeding the character limit and continue typing on first name field
Expected Result:
Users should not enter more than the specified limit of characters
Actual Result:
Users can enter more characters than the specified limit in the First name and Last name fields and removed extra characters after pressing space button
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.13.4 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Users can enter more characters than the specified limit[/-][+][HOLD on #18647] Users can enter more characters than the specified limit[/+]on May 15, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
I don't think that we need to add this case. It's a bit extreme that people would enter more than 100 chars into a name field, so I don't think we need to be explicitly testing this.
Activity
melvin-bot commentedon May 13, 2023
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 13, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)dhairyasenjaliya commentedon May 13, 2023
this can be hold in favour of #18647 still we need to decide limit
[-]Users can enter more characters than the specified limit[/-][+][HOLD on #18647] Users can enter more characters than the specified limit[/+]laurenreidexpensify commentedon May 16, 2023
Making this a weekly
laurenreidexpensify commentedon May 22, 2023
No update on #18647 so still on hold
laurenreidexpensify commentedon May 31, 2023
No update on #18647 so remains on hold again this week
113 remaining items
melvin-bot commentedon Mar 13, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 13, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
laurenreidexpensify commentedon Mar 25, 2024
@ayazhussain79 let's handle your payment in #38941
@aimane-chnaif pls complete checklist above thanks
aimane-chnaif commentedon Mar 25, 2024
This is more like feature request.
Regression Test Proposal
luacmartins commentedon Mar 25, 2024
I don't think that we need to add this case. It's a bit extreme that people would enter more than 100 chars into a name field, so I don't think we need to be explicitly testing this.
aimane-chnaif commentedon Mar 25, 2024
Thanks, we can just close this then after all payment set.