[$1000] [HOLD for payment 2023-05-25] After send money it will show "$0.00" in preview card

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Go to any chat > Send Money > any amount > confirm
3. You'll notice "$0.00" in the preview card

Expected Result:

It should should the correct amount

Actual Result:

It is showing "$0.00"

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.13-0
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @daraksha-dk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683903988041489

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a7ce0f64f44ba674
• Upwork Job ID: 1661727049853960192
• Last Price Increase: 2023-05-25

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kushu7]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After sending money its showing $0.00 in preview card

What is the root cause of that problem?

When report action type of payment is pay. we remove amount, currency, comment from originalMessage.

App/src/libs/ReportUtils.js

Lines 1327 to 1334 in 293f23b

	// We store amount, comment, currency in IOUDetails when type = pay
	if (type === CONST.IOU.REPORT_ACTION_TYPE.PAY) {
	_.each(['amount', 'comment', 'currency'], (key) => {
	delete originalMessage[key];
	});
	originalMessage.IOUDetails = {amount, comment, currency};
	originalMessage.paymentType = paymentType;
	}

We save it in originalMessage.IOUDetails.

What changes do you think we should make in order to solve the problem?

For resolving this we can do the following. when action type is pay we can read data from originalMessage.IOUDetails here :

App/src/components/ReportActionItem/IOUPreview.js

Lines 150 to 152 in 293f23b

	const requestAmount = props.isIOUAction ? lodashGet(props.action, 'originalMessage.amount', 0) : ReportUtils.getMoneyRequestTotal(props.iouReport);
	const requestCurrency = props.isIOUAction ? lodashGet(props.action, 'originalMessage.currency', CONST.CURRENCY.USD) : props.iouReport.currency;

We can modify it to:

// We store amount, comment, currency in IOUDetails when type = pay
const prefix = lodashGet(props.action, 'originalMessage.type', null) === CONST.IOU.REPORT_ACTION_TYPE.PAY ? 'originalMessage.IOUDetails' : 'originalMessage';

// If props.action is undefined then we are displaying within IOUDetailsModal and should use the full report amount
const requestAmount = props.isIOUAction ? lodashGet(props.action, `${prefix}.amount`, 0) : ReportUtils.getMoneyRequestTotal(props.iouReport);
const requestCurrency = props.isIOUAction ? lodashGet(props.action, `${prefix}.currency`, CONST.CURRENCY.USD) : props.iouReport.currency;
const requestComment = lodashGet(props.action, `${prefix}.comment`, '');

Result:

comScreen.Recording.2023-05-13.at.4.17.26.PM.mov

What alternative solutions did you explore? (Optional)

None

[trjExpensify]

Coming from the thread, @mollfpr is this due to your currency PR perhaps?

Also, this is reproducible on staging, so I've updated the OP.

[mollfpr]

@trjExpensify Probably yes. I’ll check it in the morning.

Apologise for the late response 🙏

[trjExpensify]

Sounds good! Can I co-assign you in the meantime?

[mollfpr]

Yes, please.