[$1000] Remove photo option is shown with Avatar

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create new account
2. Go to profile details
3. Click on profile avatar

Expected Result:

Default avatar should not show Remove photo option, If this is intentional then it should not even change default avatar assigned to user

Actual Result:

Default avatar is showing Remove photo option

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.9-12
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.463.mp4

Screen.Recording.2023-05-03.at.2.25.57.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @DinalJivani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683061301937559

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e798ab7cf8430379
• Upwork Job ID: 1653801710631010304
• Last Price Increase: 2023-05-03

[MelvinBot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[adelekennedy]

@marcaaron does the process change when it's a deploy blocker or should I triage as normal? The so isn't clear to me

[marcaaron]

I don't think the process changes much. Sometimes the blocker label comes off and the issue will just be a "regular' issue so it's good to have someone do an initial check. But for Deploy blockers... Engineering will probably beat you and fix it before it gets triaged :D

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove photo option is shown with Avatar

What is the root cause of that problem?

We are checking if user has default avatar in order to hide or show the remove photo option.

function isDefaultAvatar(avatarURL) {
    if (_.isString(avatarURL) && (avatarURL.includes('images/avatars/avatar_') || avatarURL.includes('images/avatars/user/default'))) {
        return true;
    }

    // If null URL, we should also use a default avatar
    if (!avatarURL) {
        return true;
    }
    return false;
}

In this case, when user replace the avatar, server return the default avatar with something like this:
https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_22.png and it make the isDefaultAvatar return false, since it doesn't match any conditions from isDefaultAvatar function.

What changes do you think we should make in order to solve the problem?

• Fix from backend, make the default avatar return with the same format with before.
• Add more condition inside isDefaultAvatar function, including the new path that return from avatar default url so isDefaultAvatar function will look like:

function isDefaultAvatar(avatarURL) {
    if (
        _.isString(avatarURL)
      && (avatarURL.includes('images/avatars/default-avatar')
        || avatarURL.includes('images/avatars/avatar_')
        || avatarURL.includes('images/avatars/user/default'))
    ) {
        return true;
    }

    // If null URL, we should also use a default avatar
    if (!avatarURL) {
        return true;
    }
    return false;
}

What alternative solutions did you explore? (Optional)