Settings - Buttons are not grey out if user switches to offline at another place

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the Expensify ND App
2. Switch to offline mode while at LHN
3. Go to Settings > Security > Close Account or Settings > Payments

Expected Result:

Button 'Close Account' is greyed out
Button 'Add payment method' is greyed out

Actual Result:

Button 'Close Account' is NOT greyed out
Button 'Add payment method' is NOT greyed out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.8.4

Reproducible in staging?: Yes

Reproducible in production?: No

Notes/Photos/Videos:

Bug6035808_iOS-offline-button-greyout.mp4

Bug6035808_Desktop-offline-button-greyout.mp4

Issue reported by: Applause - Internal Team

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[robertKozik]

Probably this PR should be fixing this regression

[MelvinBot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[cead22]

@kbecciv it looks like expected results and actual results isn't accurate, since from what I can see in the video, this is about the close account button being enabled/disabled while online/offline. Can you confirm and update those sections please? Also check out the edits I made to the description already, and let me know what you think about removing all the items for which we're not adding information in these issues to remove some of the noise

[cead22]

Separately, I understand this is happening on staging and not production, but this doesn't feel like a bug that's worth blocking a deploy over

[kbecciv]

@cead22 My apologies, corrected the expected results and actual results.

[cead22]

It looks like the fix was CP'ed to staging, and I can't reproduce on staging web. @kbecciv @robertKozik can you?