Repository navigation
[Awaiting Payment 2024-01-30] [$2000] We can send an empty message using dictation on iPhone #18121
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open App
- Go to any chat
- Press on the message composer
- Press the mic icon from the keyboard and do not speak anything
- Press the mic icon again to stop dictation
Expected Result:
If we have not spoken anything then send button should have to be disabled
Actual Result:
Send button is enabled on an empty message and we can send the empty message in the chat
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
dictate-bug.MP4
VSSR0553.1.MP4
Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682627289846559
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01fe24292fbc44e5d8
- Upwork Job ID: 1651956178824339456
- Last Price Increase: 2023-05-08
Activity
MelvinBot commentedon Apr 28, 2023
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Apr 28, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)hungvu193 commentedon Apr 28, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
We can send an empty message using dictation on iPhone
What is the root cause of that problem?
We are checking if comment is empty to disable the send button, however the result return from empty dictation in iPhone was a escape character
\ufffc, that's why our regex didn't work and button still can be enable.App/src/pages/home/report/ReportActionCompose.js
Line 578 in 6fb0969
What changes do you think we should make in order to solve the problem?
Add more condition to our isCommentEmpty's regex to prevent such thing. So our regex will look like:
What alternative solutions did you explore? (Optional)
None.
Result:
Screen.Recording.2023-04-28.at.10.08.56.mov
trjExpensify commentedon Apr 28, 2023
I can reliably reproduce this. Moving on
External.[-]We can send an empty message using dictation on iPhone[/-][+][$1000] We can send an empty message using dictation on iPhone[/+]MelvinBot commentedon Apr 28, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01fe24292fbc44e5d8
MelvinBot commentedon Apr 28, 2023
Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.
MelvinBot commentedon Apr 28, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (
External)132 remaining items
trjExpensify commentedon Jan 30, 2024
@hellohublot - paid!
trjExpensify commentedon Jan 30, 2024
@jayeshmangwani - paid!
@Santhosh-Sellavel once you confirm you've requested, I'll go ahead and close this.
trjExpensify commentedon Feb 1, 2024
Bump @Santhosh-Sellavel! Confirm you've requested, please.
trjExpensify commentedon Feb 5, 2024
Mic check 1, 2.. @Santhosh-Sellavel you there? 😅
Santhosh-Sellavel commentedon Feb 5, 2024
Will request this week. Feel free to close
trjExpensify commentedon Feb 5, 2024
Thanks!
Santhosh-Sellavel commentedon Feb 10, 2024
Requested on ND
JmillsExpensify commentedon Feb 11, 2024
$2,000 approved for @Santhosh-Sellavel based on the summary above.