[HOLD for payment 2023-05-23] Investigate how to clean up MoneyRequestModal effects

[thienlnam]

We got some cleanup that needs to happen as part of this refactor but there are some deeper problems with this logic

#16679 (comment)

Like prop iou.creatingIOUTransaction doesn't even update when the iou is created ?? Since this is holding on many other issues, we're creating a different issue to investigate more deeply

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011429e7715d32fb4d
• Upwork Job ID: 1651726628781948928
• Last Price Increase: 2023-04-27

[thienlnam]

Add this to refactor #16679 (comment)

[thienlnam]

Realizing there is a bug on main for creating money requests preventing me from running through tests https://expensify.slack.com/archives/C049HHMV9SM/p1681261358970429

[MelvinBot]

@thienlnam Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[thienlnam]

Haven't addressed the bug yet but the changes are ready

[MelvinBot]

@thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~011429e7715d32fb4d

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

[MelvinBot]

@mollfpr, @thienlnam Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[MelvinBot]

@mollfpr, @thienlnam 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!