[HOLD for payment 2023-04-14] [$1000] Selected timezone option is not scrolled initially for the timezones list

@Pujan92

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Break down in numbered steps

Goto profile page
Select Timezone

Expected Result:

Describe what you think should've happened

The selected values should be scrolled to and visible on the list.

Actual Result:

Describe what actually happened

Observe the selected value is not scrolled and visible directly on screen on opening the list

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

User has to scroll to it

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: Staging(v1.2.90-4)
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @Pujan92
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679926798768949

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015b1ab2dc02fa1f2c
Upwork Job ID: 1643213233754124288
Last Price Increase: 2023-04-04

@lschurr

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Job added to Upwork: https://www.upwork.com/jobs/~015b1ab2dc02fa1f2c

@lschurr

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

@sobitneupane

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@mountiny

Current assignee @mountiny is eligible for the External assigner, not assigning anyone new.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Selected timezone option isn't get scrolled initially

What is the root cause of that problem?

We are not setting the initiallyFocusedOptionKey correctly which is causing this issue.

What changes do you think we should make in order to solve the problem?

App/src/pages/settings/Profile/TimezoneSelectPage.js

Line 142 in 10d3d52

initiallyFocusedOptionKey={this.currentSelectedTimezone}

this.currentSelectedTimezone should be replaced with this.timezone.selected
App/src/pages/settings/Profile/TimezoneSelectPage.js

Lines 74 to 76 in 10d3d52

getKey(text) {

return `${text}-${(new Date()).getTime()}`;

}

We can get rid of the function getKey in TimezoneSelectPage and pass the text for keyForList like the way it was earlier.

What alternative solutions did you explore? (Optional)

I am not sure why this(getKey) is required but if it remains then we need to consider text here instead of keyForList

App/src/components/OptionsSelector/BaseOptionsSelector.js

Line 159 in 10d3d52

    
           const indexOfInitiallyFocusedOption = _.findIndex(allOptions, option => option.keyForList === this.props.initiallyFocusedOptionKey);

Screen.Recording.2023-03-24.at.8.13.09.PM.mov

@mountiny

@mountiny @sobitneupane - Are we still good to continue working through the BZ checklist on this one? Do we need a new regression test?

@sobitneupane

Is there any regression test for this? cc @sobitneupane

@sobitneupane

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane / @mountiny] The PR that introduced the bug has been identified. Link to the PR:

#15176

[@sobitneupane / @mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#15176 (comment)

[@sobitneupane / @mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://expensify.slack.com/archives/C049HHMV9SM/p1681279519887149

Regression Test Proposal

Go to Settings -> Profile -> Timezone
Make sure "Automatically determine your location" toggle is turned off and Tap on timezone
Verify that currently selected timezone is marked and visible without scrolling

Do we agree 👍 or 👎

@lschurr

Thank you Sobit 🙇

@lschurr this should be ready

Added regression test request: https://github.com/Expensify/Expensify/issues/275503

@alexxxwork

@alexxxwork and @sobitneupane - Could you apply for the job: https://www.upwork.com/jobs/~015b1ab2dc02fa1f2c

@lschurr

Thanks @lschurr. Applied

@alexxxwork

@alexxxwork and @sobitneupane - Could you apply for the job: https://www.upwork.com/jobs/~015b1ab2dc02fa1f2c

Shall I apply for reporting the issue?

@lschurr

@lschurr I've applied, thank you.

@Pujan92

Shall I apply for reporting the issue?

Yes @Pujan92!

All paid. Closing!

Navigation Menu

Repository navigation

[HOLD for payment 2023-04-14] [$1000] Selected timezone option is not scrolled initially for the timezones list #16905

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

50 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	getKey(text) {
	return `${text}-${(new Date()).getTime()}`;
	}

[HOLD for payment 2023-04-14] [$1000] Selected timezone option is not scrolled initially for the timezones list #16905

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

MelvinBot commented on Apr 4, 2023

MelvinBot commented on Apr 4, 2023

Bug0 Triage Checklist (Main S/O)

MelvinBot commented on Apr 4, 2023

MelvinBot commented on Apr 4, 2023

MelvinBot commented on Apr 4, 2023

MelvinBot commented on Apr 4, 2023

Pujan92 commented on Apr 4, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

50 remaining items

lschurr commented on Apr 11, 2023

mountiny commented on Apr 11, 2023

sobitneupane commented on Apr 12, 2023

sobitneupane commented on Apr 12, 2023

mountiny commented on Apr 12, 2023

lschurr commented on Apr 12, 2023

lschurr commented on Apr 13, 2023

sobitneupane commented on Apr 13, 2023

Pujan92 commented on Apr 13, 2023

alexxxwork commented on Apr 13, 2023

lschurr commented on Apr 13, 2023

lschurr commented on Apr 14, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions