Skip to content

[HOLD for payment 2023-06-15] [Navigation Reboot] Update RHP to be encapsulated in another navigator #15848

Closed

Description

@mountiny

Tracking issue #11768

Created a new branch navigation-refactor to which we will merge all the PRs of this refactor.

Update the right modal to be encapsulated in another navigator.

Bookmark in the doc

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011dc9881a445d34df
  • Upwork Job ID: 1634919787249025024
  • Last Price Increase: 2023-03-12

Activity

  1. self-assigned this
    on Mar 10, 2023
  2. locked and limited conversation to collaborators on Mar 10, 2023
  3. unlocked this conversation on Mar 10, 2023
  4. adamgrzybowski commented on Mar 12, 2023

    @adamgrzybowski
    Contributor

    Going to implement this

  5. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 12, 2023
  6. MelvinBot commented on Mar 12, 2023

    @MelvinBot
    Contributor
  7. MelvinBot commented on Mar 12, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

  8. mountiny commented on Mar 13, 2023

    @mountiny
    ContributorAuthor

    Not overdue, gonna be implementing this week.

  9. 23 remaining items

  10. MelvinBot commented on Apr 12, 2023

    @MelvinBot
    Contributor

    @mountiny, @adamgrzybowski Whoops! This issue is 2 days overdue. Let's get this updated quick!

  11. mountiny commented on Apr 12, 2023

    @mountiny
    ContributorAuthor

    Actively being worked on

  12. MelvinBot commented on Apr 20, 2023

    @MelvinBot
    Contributor

    @mountiny, @adamgrzybowski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  13. mountiny commented on Apr 20, 2023

    @mountiny
    ContributorAuthor

    Actively being worked on

  14. mountiny commented on Apr 22, 2023

    @mountiny
    ContributorAuthor

    Good to close

  15. melvin-bot commented on Jun 7, 2023

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  16. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 8, 2023
  17. changed the title [-][Navigation Reboot] Update RHP to be encapsulated in another navigator[/-] [+][HOLD for payment 2023-06-15] [Navigation Reboot] Update RHP to be encapsulated in another navigator[/+] on Jun 8, 2023
  18. melvin-bot commented on Jun 8, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  19. melvin-bot commented on Jun 8, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.25-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-06-15. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringInternalRequires API changes or must be handled by Expensify staffNewFeatureSomething to build that is a new item.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions