Typing a non-roman language and hitting enter sends text prematurely

[hayata-suenaga]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open NewDot on Laptop Chrome or Desktop App
2. Open a chat room
3. Type Japanese
   You can find information on how to enable Japanese keyboard (choose "Japanese - Romaji"). You probably see Japanese characters and English characters mixed up if you type randomly, but it's okay. Only thing that matters is that you're using the input mode for Japanese language.
   You can also try with Chinese ("Chinese, Simplified -> Pinyin - Simplified") or Korean ("2-Set Korean")
4. Hit enter.

Expected Result:

When you hit enter, the text should not be sent immediately. With non-roman languages that require you to make selection, the first time you hit enter, the text should be selected, not sent.

Actual Result:

Test is send without selection, while the text entered remained on the text input box.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome only
  On Safari, hitting enter doesn't leave the text in the input box, it still causes premature submission of the text message.
• MacOS / Desktop

Version Number: v1.2.80-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-03-09.at.2.15.44.PM.mov

This is the behavior on Slack when I type Japanese

Screen.Recording.2023-03-09.at.2.21.38.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: Internal engineer
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dda087fd8bec30ac
• Upwork Job ID: 1636562209124208640
• Last Price Increase: 2023-03-17

[MelvinBot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    - [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync No Slack thread

[hayata-suenaga]

@johncschuster when you finish the Triage Checklist, I'd appreciate it if you mark this issue internal and assign it to me. I'd like to work on this issue.

[MelvinBot]

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@johncschuster Huh... This is 4 days overdue. Who can take care of this?

[hayata-suenaga]

I'll start working on this issue

[hayata-suenaga]

The issue exists wherever we're listening for the key event for Enter to invoke submission callbacks.

Screen.Recording.2023-03-15.at.3.19.51.PM.mov

Uploading Screen Recording 2023-03-16 at 7.34.41 PM.mov…