Repository navigation
[HOLD on react-native#37248] [$2000] Last dot for longer name or email on user details page is cut to half #15541
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open the app on android
- Open any report whose username (if name is set) is very long or if no name is set, whose email is very long
- Click on their name to open the user details page
- Observe last dot
Expected Result:
App should display 3 dots properly without any cutting of dots
Actual Result:
Last dot is cut to half
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.2.76-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
last.dot.cut.to.half.android.app.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677492027940559
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0192355c5c5e373940
- Upwork Job ID: 1630867151496368128
- Last Price Increase: 2023-03-15
Activity
MelvinBot commentedon Feb 28, 2023
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Feb 28, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)[-]On android app, last dot for longer name or email on user details page is cut to half [/-][+]Last dot for longer name or email on user details page is cut to half [/+]twisterdotcom commentedon Feb 28, 2023
Can I get the opinion of @Expensify/design here as to whether this is something we care about? It is very minor, but I see that we don't cut it off in the 2nd and 3rd fields, just the header:
shawnborton commentedon Feb 28, 2023
Hmm yeah, I would say this is a bug since the dots should appear visible. So it looks like only our headline font is affected. I'm not entirely sure how to solve this though - we might need to add an extra 1px or so of padding on the right side of the name?
twisterdotcom commentedon Mar 1, 2023
Cool, let's see what our contributors come up with! Just wanted an opinion on our expectations - thanks @shawnborton.
[-]Last dot for longer name or email on user details page is cut to half [/-][+][$1000] Last dot for longer name or email on user details page is cut to half [/+]MelvinBot commentedon Mar 1, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0192355c5c5e373940
MelvinBot commentedon Mar 1, 2023
Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.
90 remaining items
BeeMargarida commentedon May 3, 2023
I'll be out of office today due to a national holiday, but will open PR upstream tomorrow
BeeMargarida commentedon May 4, 2023
Upstream PR: react/react-native#37248
[-][$2000] Last dot for longer name or email on user details page is cut to half [/-][+][HOLD on react-native#37248] [$2000] Last dot for longer name or email on user details page is cut to half [/+]twisterdotcom commentedon May 17, 2023
Looks like we're close to merging.
BeeMargarida commentedon May 22, 2023
Update: The PR was merged and the issue on their side was closed
twisterdotcom commentedon May 22, 2023
Nice! Okay, what do we need to do to close this now then?
BeeMargarida commentedon May 22, 2023
I would say update Expensify's react native fork with the commit with the fix. I'm not sure what's your process regarding that, do you cherry-pick the commits you want, or update based on RN versions?
twisterdotcom commentedon May 24, 2023
Asking internally: https://expensify.slack.com/archives/C01SKUP7QR0/p1684930629410309
twisterdotcom commentedon May 24, 2023
Cool, discussed with @mountiny internally and I think we can call this fixed now and it will merge eventually.
@dhanashree-sawant and @thesahindia - could you apply here for $250, and $1k respectively: https://www.upwork.com/jobs/~0192355c5c5e373940
@BeeMargarida - this is covered by our normal Callstack arrangement I believe.
dhanashree-sawant commentedon May 24, 2023
Hi @twisterdotcom, the upwork job is no longer available.
AndrewGable commentedon May 29, 2023
Congrats on the upstream PR merge 🎉
twisterdotcom commentedon Jun 2, 2023
All paid!