Skip to content

[HOLD #11768] [$8000] Chat room wobbles while opening up on mobile Chrome or Safari #15239

Closed

Description

@hayata-suenaga

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the production NewDot on mobile Chrome or Safari at https://new.expensify.com
  2. Open a chat room several times
  3. Check that chat room wobbles while opening and that
  4. Extra: Open the same chat room several times. Sometimes the room opens up with keyboard and sometimes without keyboard. I'm not sure if this is the expected behavior.

Expected Result:

Opening chat room should be smooth

Actual Result:

Opening chat room is not smooth

Workaround:

Users can still use the app.

RPReplay_Final1676603610.MOV

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.2.72-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01902d9184e4d55eb3
  • Upwork Job ID: 1626701164545208320
  • Last Price Increase: 2023-03-10

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 17, 2023
  2. locked and limited conversation to collaborators on Feb 17, 2023
  3. MelvinBot commented on Feb 17, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. MelvinBot commented on Feb 17, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. JmillsExpensify commented on Feb 17, 2023

    @JmillsExpensify
    Contributor

    Hmm, this is an interesting one. I can pretty consistently reproduce the screen wobbling and bouncing around in the following flow as well:

    • Global create
    • New group
    • Choose members

    And at that point, the chat wobbles around in a similar fashion. I have a feeling that it's the combination of the keyboard becoming active and then the room sliding into view at the same time? In any case, Let's open this open to the community and see if we have any realistic fixes or if this is a known upstream issue.

  6. JmillsExpensify commented on Feb 17, 2023

    @JmillsExpensify
    Contributor

    This bug is not a duplicate report (check E/App issues and #expensify-bugs)

    I did search /App and #expensify-bugs and wasn't able to find anything specific to this issue, though I do know we've had plenty of discussions around transitions and animations in the app.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 17, 2023
  8. unlocked this conversation on Feb 17, 2023
  9. changed the title [-]Chat room wobbles while opening up on mobile Chrome or Safari[/-] [+][$1000] Chat room wobbles while opening up on mobile Chrome or Safari[/+] on Feb 17, 2023
  10. MelvinBot commented on Feb 17, 2023

    @MelvinBot
    Contributor
  11. MelvinBot commented on Feb 17, 2023

    @MelvinBot
    Contributor

    Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

  12. MelvinBot commented on Feb 17, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

  13. 80 remaining items

  14. youssef-lr commented on May 8, 2023

    @youssef-lr
    Contributor

    Seems like with this PR merged this issue is fixed, can you confirm please @hayata-suenaga @aimane-chnaif?

  15. aimane-chnaif commented on May 8, 2023

    @aimane-chnaif
    Contributor

    Here's link for testing that branch

  16. youssef-lr commented on Jun 9, 2023

    @youssef-lr
    Contributor

    bump! Is this fixed now and can be off hold? I tested this recently and I sort of can still see a wobble.

  17. mountiny commented on Jun 22, 2023

    @mountiny
    Contributor

    I believe this issue is also similar/ same rootcause so we could have only one of these #7737

  18. aimane-chnaif commented on Jun 22, 2023

    @aimane-chnaif
    Contributor

    Well, I think it's different issue.
    This issue is about switching pages with auto-focus input and showing keyboard (vertical issue), while #7737 is related to swipe animation (horizontal issue).

  19. mountiny commented on Jun 23, 2023

    @mountiny
    Contributor

    Thanks for confirming, is this still reproducible? @aimane-chnaif ?

  20. aimane-chnaif commented on Jul 24, 2023

    @aimane-chnaif
    Contributor

    #11768 was already done. I think it's much improved but still not smooth on mSafari.
    @hayata-suenaga can you please test again?

  21. hayata-suenaga commented on Jul 24, 2023

    @hayata-suenaga
    ContributorAuthor
  22. JmillsExpensify commented on Jul 24, 2023

    @JmillsExpensify
    Contributor

    Note for myself. No payout required here (already filed correctly in the project).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.InternalRequires API changes or must be handled by Expensify staffMonthlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions