Payment for E/E issue #240970

[mallenexpensify]

Need to pay out
E/E GH - https://github.com/Expensify/Expensify/issues/240970
PR - #13898

$1000 to @eVoloshchak

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b5a6fdbdbdead3bf
• Upwork Job ID: 1620608464115429376
• Last Price Increase: 2023-02-01

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b5a6fdbdbdead3bf

[melvin-bot]

Current assignee @eVoloshchak is eligible for the Internal assigner, not assigning anyone new.

[mallenexpensify]

@eVoloshchak can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01b5a6fdbdbdead3bf

[eVoloshchak]

Accepted

This PR caused a regression here.
The issue didn't happen on PR branch test but happened only after merge, #14289 deleted the import we were using.
Both branches were working perfectly before the merge, linter checks were successful for both, but there is no linter check after you merge a PR into main.
I could have caught it when reviewing if I tested the changes against latest main, so it's probably worth adding Tested against main item to the reviewer checklist.
However, that still will not prevent similar issues if C+ does the review against main, after which other conflicting PR gets merged, and then the current PR is merged by an Expensify engineer.

So as @aimane-chnaif correctly pointed out

This is a good example why we should re-test after merging into main or merge from main before review and test

I'd say we even need to re-test after merging into main AND merge from main before review

UPD: started a slack thread here

[jayeshmangwani]

@eVoloshchak can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~01b5a6fdbdbdead3bf

@mallenexpensify should I also apply for reporting regression ?

[jayeshmangwani]

@eVoloshchak can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~01b5a6fdbdbdead3bf

@mallenexpensify should I also apply for reporting regression ?

hey @mallenexpensify , can you please help here, I have reported a regression from this PR, am I eligible for report regression here ?