Error doesn't disappear in Request a call page when user try to type new information

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open Request a Call page.
3. Try to type invalid phone number and submit, it will show the error, try to enter valid phone number.
4. Notice that error still appears.

Expected Result:

Error should disappear when you try to enter new phone number.

Actual Result:

Error still appears after user enter new valid phone number.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.61-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-01-30.at.17.35.40.mov

Recording.1406.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675074965900229

View all open jobs on GitHub

[MelvinBot]

Still overdue 6 days?! Let's take care of this!

[gedu]

Hi, Eduardo from Callstack, can I take this bug?

[gedu]

Proposal

Please re-state the problem that we are trying to solve in this issue.
Typing an invalid phone number and submitting, it will show the error, trying to enter a valid phone number doesn't make the error disappear

What is the root cause of that problem?
After submitting, into the Onyx state the error field is updated to show the error above the submit button, and typing a new phone number, doesn't reset/clear this Onyx error state.

What changes do you think we should make in order to solve the problem?
We should listen to the 'onChangeText' from the TextInput and if Onyx has an error, clear it. This will update the UI and remove the error label above the submit button. This also will remove any error after submission, which I think makes sense because the user will try to request a new call with a new number.
On the other hand, I updated the placeholder because all the errors labels show the number with a +1, also the Regex E164_REGEX checks that start with +1 validate the phone number, so I thought will be good to match the error labels with the suggestion (placeholder), this updated isn't needed to fix the bug.

[mountiny]

@gedu Thanks! I know its not easy sometimes, but try to avoid adding the diffs to the proposals and more describe what needs to be done in plain English.

Please feel free to submit the PR for this 🙇