Repository navigation
[HOLD for payment 2023-02-10] [$1000] Android - Payment- White line appears when clicking on "Add Payment method" button #14563
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Launch the app
- Log i with any account
- Tab Setting>Payment
- Tab button Add payment method
Expected Result:
No white line appears when clicking on "Add Payment method" button
Actual Result:
White line appears when clicking on "Add Payment method" button
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
Version Number: 1.2.59.1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5911544_android_flash_2501.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01dc6f5499efed1dd6
- Upwork Job ID: 1619005122333753344
- Last Price Increase: 2023-01-27
Activity
[-]Android - Payment- White line appears when clicking on "Add Payment method" button[/-][+][$1000] Android - Payment- White line appears when clicking on "Add Payment method" button[/+]melvin-bot commentedon Jan 27, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01dc6f5499efed1dd6
melvin-bot commentedon Jan 27, 2023
Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.
flaviadefaria commentedon Jan 27, 2023
It's a subtle one but was able to reproduce it.
melvin-bot commentedon Jan 27, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)melvin-bot commentedon Jan 27, 2023
Triggered auto assignment to @arosiclair (
External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.32 remaining items
flaviadefaria commentedon Feb 13, 2023
@mollfpr @arosiclair @situchan please fill out the checklist above. Did the PR introduce a bug?
arosiclair commentedon Feb 13, 2023
Since this is an upstream issue with react-native-modal, this may have never worked correctly but became more noticeable after our redesign. What do you think @mollfpr?
mollfpr commentedon Feb 13, 2023
@arosiclair Yeah, I agree with you.
mollfpr commentedon Feb 14, 2023
@situchan Could you propose the regression test for this issue? Thanks!
situchan commentedon Feb 14, 2023
Actually, regression test will be same as in QA step.
Regression Test Proposal
mollfpr commentedon Feb 14, 2023
@arosiclair Is it possible to add the regression test if the issue is regarding the app's appearance?
flaviadefaria commentedon Feb 14, 2023
@situchan was assigned on Jan 31st. PR Merged on Feb 2nd = 50% bonus for @situchan and @mollfpr.
I'll pay you both now.
flaviadefaria commentedon Feb 14, 2023
Alright, I have now paid @situchan and @mollfpr.
Waiting on @arosiclair to see if we need to add a regression test.
arosiclair commentedon Feb 15, 2023
IMO I don't think this regression test is needed, but I asked in slack here
flaviadefaria commentedon Feb 15, 2023
Thanks @arosiclair! Just saw the Slack thread and since we don't need to add a regression test and everyone has been paid we're good to close this issue. Thanks, everyone!