[HOLD for payment 2023-02-02] Intercept Pusher + UrbanAirship notifications and only apply sequenceNumber-keyed updates

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Coming from https://expensify.slack.com/archives/C04DC6LU2UB/p1674243288556829?thread_ts=1674242808.964579&cid=C04DC6LU2UB

Problem

Pusher + UrbanAirship notifications may include ReportActions Onyx updates. However, we're in the process of re-keying reportActions to be keyed in Onyx by their reportActionID instead of their sequenceNumber. You can see the PR for that here.

Solution (part 1)

This issue represents part 1 of the rollout plan laid out here.

The task for this issue is to create an E/App PR with a temporary hack that intercepts Pusher / UrbanAirship Onyx updates, finds any reportActions updates, looks at the payload, and discards any update in which reportActions are not keyed by sequence-.

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bd6dfaa7206afad4
• Upwork Job ID: 1616591563120336896
• Last Price Increase: 2023-01-21

[roryabraham]

PR merged, CPing to staging for #urgency here.

[iwiznia]

I know we reverted the PR, but commenting here to let you know that when it was deployed, it also caused this. Just so that we can test that next time to ensure it does not happen again.

[iwiznia]

ok, seems the revert did not change the behavior, some people can still reproduce the issue I was seeing (but not me)

[roryabraham]

The code merged for this has since been reverted, and we decided not to implement this.