[HOLD for payment 2023-02-07] [$1000] Web - Log out - Console error is displayed when log out

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with expensifail account
3. Go to Setting - Sign out

Expected Result:

Console error is not displayed when log out

Actual Result:

Console error is displayed when log out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Web / Chrome / Safari

Version Number: 1.2.55.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers): applausetester+0901abb@applause.expensifail.com/Feya87Katya

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.2010.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015d869c70481d179b
• Upwork Job ID: 1617488772668575744
• Last Price Increase: 2023-01-23

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcaaron]

On first glance this error looks kind of harmless - but also like it is coming from the Pusher JS lib?

Are there any observable bad effects here? Or just a console error?

[marcaaron]

I can reproduce this. Suspect it happens because we have already disconnected from Pusher when we try to unsubscribe from the report channel here:

App/src/pages/home/report/ReportActionsView.js

Line 248 in 3661b57

Report.unsubscribeFromReportChannel(this.props.report.reportID);

The only PR I found related to logging out is here: https://github.com/Expensify/App/pull/13886/files

But not really connecting that change with the Pusher error. Probably will require some debugging.

Not sure if this is a "blocker" though. The error does look a bit harmless - but obviously would be ideal to not see it at all.

I want to say one solution would be to prevent unsubscribing if there is no websocket connection, but not really sure if that's correct to assume. And also doesn't quite explain the root cause of why this error has begun showing up.

[marcaaron]

Update: Only managed to reproduce 1/5 sign outs on staging - so I think most likely this is harmless and should be downgraded to "not blocker" while we continue to investigate - removing the label.