Repository navigation
[HOLD for payment 2023-03-13] [$4000] Able to change timezone through direct link even when the automatically determine location switch is on #14340
Description
Activity
- locked and limited conversation to collaborators
on Jan 16, 2023 I can replicate the reported behavior. Setting the timezone via the link does not update the timezone set on my profile or in the timezone selection list. Looks like making the change via the link does not override the "automatically determine toggle"
Team agreed that the behavior described here isn't ideal. Suggested solution is when
Automatically determine your locationthen redirect https://new.expensify.com/settings/profile/timezone/select back to https://new.expensify.com/settings/profile/timezone- unlocked this conversation
on Jan 26, 2023 - changed the title
[-]Able to change timezone through direct link even when the automatically determine location switch is on[/-][+][$1000] Able to change timezone through direct link even when the automatically determine location switch is on[/+]on Jan 26, 2023 Job added to Upwork: https://www.upwork.com/jobs/~01b8d0920a25d93b4f
103 remaining items
@kevinksullivan Got the offer and accepted now! Thanks 👍
@tylerkaraszewski, @kevinksullivan, @mollfpr, @priyeshshah11 Whoops! This issue is 2 days overdue. Let's get this updated quick!
@kevinksullivan - this issue shows as overdue but I'm not sure what action we're waiting on. A PR from @priyeshshah11 ?
Just waiting to finish payment @tylerkaraszewski
@priyeshshah11 it looks like the offer is still pending... Does it show as accepted on your end?
@priyeshshah11 it looks like the offer is still pending... Does it show as accepted on your end?
@kevinksullivan accepted & requested payment
sheesh, sorry about all the back and forth @priyeshshah11 . It seems I finally got this to work. Closing out!
Reacted by Priyesh Shah
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The controls should be disabled, with only the ability to go back
Actual Result:
After updating the timezone directly through the link, the new timezone is displayed on the timezone initial page, but
The old timezone is displayed on the profile page
The old timezone is selected on the timezone list page
The automatically determine location switch doesn't work
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.54-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Screen.Recording.2023-01-16.at.5.32.35.PM.mov
Recording.1305.mp4
Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1673873060216069
View all open jobs on GitHub
Upwork Automation - Do Not Edit