Repository navigation
[$1000] Chat - Error message displayed when using 2 rows with four backticks #14030
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR #13941
Action Performed:
- Go to staging.new.expensify.com
- Log in with any account
- Select any conversation
- Type 2 rows with 4 brackets
Expected Result:
No error message should be seen; message should match Slack's behavior (a single backtick on two lines, within a <pre> block)
Actual Result:
Error message displayed when using 2 rows with four brackets
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.2.49.0
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Recording.1947.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~014c69ea8eddb49796
- Upwork Job ID: 1611395276911079424
- Last Price Increase: 2023-01-06
Activity
luacmartins commentedon Jan 5, 2023
cc @tgolen since it seems related to #13941
tgolen commentedon Jan 6, 2023
Well, will wonders never cease? That's a backend error, right? Let's be sure to fix it there. I wonder what the error could be...
isabelastisser commentedon Jan 6, 2023
I'm able to reproduce this:
Brackets.bug.mp4
[-]Chat - Error message displayed when using 2 rows with four brackits[/-][+][$1000] Chat - Error message displayed when using 2 rows with four brackits[/+]melvin-bot commentedon Jan 6, 2023
Job added to Upwork: https://www.upwork.com/jobs/~014c69ea8eddb49796
melvin-bot commentedon Jan 6, 2023
Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Jan 6, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (
External)27 remaining items
aimane-chnaif commentedon Jan 13, 2023
Maybe
Externallabel confused you. We should have removed it and addedInternalinstead.aimane-chnaif commentedon Jan 13, 2023
Here's PR
melvin-bot commentedon Jan 13, 2023
Current assignee @aimane-chnaif is eligible for the Internal assigner, not assigning anyone new.
Prince-Mendiratta commentedon Jan 13, 2023
Hello @aimane-chnaif , @dangrous glad to see this issue resolved! I was wondering if I am eligible for a bonus for this as well? I helped out in the RCA, testing and fix. I was working on the regex solution myself and was testing it out but @dangrous sent his regex in the Slack thread so I went on to test that out instead. I would appreciate if it's possible but thanks anyways, I learnt a lot about the composer flow with this issue. :D
dangrous commentedon Jan 13, 2023
Hey @Prince-Mendiratta (and @aimane-chnaif) I think that makes sense to me - you were helpful in getting this sorted out. We can definitely send over a bit of a bonus! cc @isabelastisser
melvin-bot commentedon Jan 20, 2023
@dangrous, @isabelastisser, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
aimane-chnaif commentedon Jan 20, 2023
The solution was deployed to production on Jan 18. #14244 (comment) This commit hash is after our commit. cc: @dangrous
Issue title needs updated accordingly cc: @isabelastisser
isabelastisser commentedon Jan 20, 2023
Update: Invited @aimane-chnaif and @Prince-Mendiratta to this job in Upwork.
isabelastisser commentedon Jan 23, 2023
Update: @aimane-chnaif and @Prince-Mendiratta were paid. All set!
isabelastisser commentedon Jan 23, 2023
Hey @danieldoglas and @aldo-expensify, can I change this to
Weekly?dangrous commentedon Jan 24, 2023
Do we still do the 7-day window for these if it's an internal PR? If not, I think we can go ahead and close, right? I don't remember what our process is for that.
dangrous commentedon Jan 26, 2023
I'm going to go ahead and close this since I believe everyone is paid and we've passed 7 days - should anyone disagree (or I do not have the right information), feel free to reopen!