Repository navigation
[HOLD for payment 2023-01-13] Backtick only message is not allowed when sending a message (but allowed when editing) #13854
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open the app
- Go to any chat
- Write only ` and/or whitespace
- Try to send it
Expected Result:
User should be able to send only backticks as a message
Actual Result:
Can't send backticks as a message
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.2.44-0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
not.allowed.mp4
Recording.1162.mp4
Expensify/Expensify Issue URL:
Issue reported by: @daraksha-dk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671730547465899
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01cb6a160bee7f24a5
- Upwork Job ID: 1610022717350330368
- Last Price Increase: 2023-01-02
Activity
tgolen commentedon Jan 2, 2023
I'll grab this and fix it
tgolen commentedon Jan 2, 2023
I found that this is expected behavior that was put in place to fix this problem: #7971 but I do think we should allow any content for messages and I would like to look into why the backend struggles with messages that only contain backticks.
tgolen commentedon Jan 2, 2023
I found that allowing backticks seems to work just fine with the backend:
The messages remain after switching chats and even after refreshing
sakluger commentedon Jan 4, 2023
@tgolen you mentioned that you created a PR to fix this, but I don't see it linked to the issue. Mind commenting with the PR link?
tgolen commentedon Jan 5, 2023
Strange, GH doesn't seem to be linking things properly. The PR is here: #13941
mountiny commentedon Jan 5, 2023
Unlocked this.
This is an issue we are trying to fix somehow, when locked, not even the github linking works and worst, it does not backgil retrospectively
sakluger commentedon Jan 5, 2023
@daraksha-dk and @Santhosh-Sellavel I sent you both offers through Upwork, please accept when you have a chance, thanks!
[-]Backtick only message is not allowed when sending a message (but allowed when editing)[/-][+][HOLD for payment 2023-01-13] Backtick only message is not allowed when sending a message (but allowed when editing)[/+]sakluger commentedon Jan 7, 2023
@daraksha-dk I paid you the reporting bonus, thanks!
@Santhosh-Sellavel thanks for accepting the offer in Upwork, the PR was just deployed to production today so payment will be next Friday as long as there are no regressions.
sakluger commentedon Jan 14, 2023
I paid everyone, ended the contracts, and closed the Upwork post. Thanks everyone!