[HOLD #11768] [$1000] Android - Split Bill - Keyboard is not dismissed for a brief moment after changing currency

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Actions Performed:

1. Go to any chat
2. Go To Split Bill
3. Change Currency

Expected Result:

Keyboard dismissed

Actual Result:

Keyboard Appears For A brief Second.

Workaround:

unknown

Platform:

Where is this issue occurring?

• Android

Version Number: 1.2.37-2
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Record_2022-12-08-05-56-42.mp4

az_recorder_20221208_181448.mp4

Expensify/Expensify Issue URL:
Issue reported by: @syedsaroshfarrukhdot
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1670461227037229

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0170d39fa04a453e03
• Upwork Job ID: 1601056856164556800

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[syedsaroshfarrukhdot]

Proposal:-

In IOUCurrencySelection.js we need to pass Keyboard.dismiss(); in confirmCurrencySelection function.

diff --git a/src/pages/iou/IOUCurrencySelection.js b/src/pages/iou/IOUCurrencySelection.js
index b7affe898..6525a205f 100644
--- a/src/pages/iou/IOUCurrencySelection.js
+++ b/src/pages/iou/IOUCurrencySelection.js
@@ -1,4 +1,5 @@
 import React, {Component} from 'react';
+import { Keyboard } from 'react-native';
 import PropTypes from 'prop-types';
 import {withOnyx} from 'react-native-onyx';
 import _ from 'underscore';
@@ -105,6 +106,7 @@ class IOUCurrencySelection extends Component {
      */
     confirmCurrencySelection(option) {
         IOU.setIOUSelectedCurrency(option.currencyCode);
+        Keyboard.dismiss();
         Navigation.goBack();
     }
 

After Fix:-

Screen.Recording.2022-12-08.at.6.19.56.AM.mov

[JmillsExpensify]

Ok, I can reproduce this.

Screen.Recording.2022-12-08.at.21.29.28.mov

[JmillsExpensify]

Here's my take: This is a pretty cosmetic bug in my opinion, as it doesn't really affect the user experience and the keyboard does dismiss automatically. So I think the value of fixing this big is pretty low.

That said, if we can find a simple solution for this then it'll be worth it. Let's open this up for proposals and see where we get.

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0170d39fa04a453e03

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)