Repository navigation
[$250] Android narrow/low pixel tablets - Chat - The FAB button disappears or is covered by the keyboard in horizontal #12592
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR #12345
Action Performed:
- Open the App
- Login with any account
- Go to any chat room
- Go to horizontal mode
- Focus on composer input to show keyboard
Expected Result:
The FAB button shouldn't floats to the top and sticks above the keyboard
Actual Result:
The FAB button disappears or is covered by the keyboard
Workaround:
Unknown
Platform:
Where is this issue occurring?
- Android -model Xiaomi Mi Pad - Android 8.1
Version Number: 1.2.25.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5813586_12345_Android.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:
Activity
melvin-bot commentedon Nov 9, 2022
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.jliexpensify commentedon Nov 11, 2022
Reassigning to Kadie as I'm about to head OOO
kadiealexander commentedon Nov 14, 2022
Asking for someone with an iPad to reproduce - https://expensify.slack.com/archives/C01GTK53T8Q/p1668402566426039
kadiealexander commentedon Nov 16, 2022
Reproduced here: https://expensify.slack.com/archives/C01GTK53T8Q/p1668409849644459?thread_ts=1668402566.426039&cid=C01GTK53T8Q
melvin-bot commentedon Nov 16, 2022
Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Nov 16, 2022
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)21 remaining items
iwiznia commentedon Nov 25, 2022
I have a PR here #13043
But while testing, I realized that I can't really reproduce this issue on neither of the 2 ipad emulators I tried (ipad mini and ipad pro) and neither on the android emulator tablet (Pixel C).
The reason is that all of them seem to always show the big screen view (ie the one with LHN and main pane), so while my PR could make it that they don't rotate, that would mean a worse UX for the user.
My guess is this is only reproducible on tablets with a narrow form factor or less pixel density.
So the question is: do we still want to lock tablets to portrait mode? I think the answer is no and we rather have this small bug on old tablets than preventing users from rotating their tablets (which for lots of users will work fine).
If you agree, let's close this.
JmillsExpensify commentedon Nov 26, 2022
Assigning myself as well since we lost the BZ assignment somehow. Also chiming in on @iwiznia's question above.
Hmm, yeah I'm with you. I tried to reproduce this on my iPad mini and I wasn't able to. So I think I'm with you, we should close this. In fact, I'll do that but ahead of doing so I will update the title to remove iPad for clarity.
[-][$250] IPAD/Android - Chat - The FAB button disappears or is covered by the keyboard in horizontal[/-][+][$250] Android narrow/low pixel tablets - Chat - The FAB button disappears or is covered by the keyboard in horizontal[/+]iwiznia commentedon Nov 28, 2022
To clarify, it's reproducible on older/smaller ipads.
0xmiroslav commentedon Nov 28, 2022
This is still reproducible in latest version of android. So I suggest to reopen this issue and put on hold until #13106 is merged
melvin-bot commentedon Nov 29, 2022
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
JmillsExpensify commentedon Nov 29, 2022
@0xmiroslav for clarity, is it reproducible on non-tablets or just tablets? Reason being, we don't officially support tablets, though I'm more than happy to re-open if you think it's going to be fixed anyway.
0xmiroslav commentedon Nov 29, 2022
This happens on android tablets with small size as explained in issue title
JmillsExpensify commentedon Nov 29, 2022
Ok yeah, so all those are unsupported devices. In the interest of focus, let's just keep this closed. We need to tackle tablet support one day, but now isn't the time.
mananjadhav commentedon Nov 29, 2022
I agree with @JmillsExpensify. We're focused on items such as BugZero, WAQ, and Dark theme, etc. Tablets isn't the focus right now, and I think we should tackle tablets sometime in future.