[HOLD for payment 2022-11-29] Redbrick path broken for Settings > Workspaces

[aldo-expensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

The red dots showing the path of an error is interrupted

Action Performed:

Using an account that is a domain

1. Create a workspace in New Dot
2. Go to old dot and set the workspace as the preferred policy of a domain's group
3. In new dot, try to delete the workspace, this will cause the API to throw an error
4. Check that the red bricks path is broken at the Settings level. The Workspaces entry should have a red dot.

Screen.Recording.2022-10-31.at.4.18.06.PM.mov

Expected Result:

The should have been a red dot next to the Workspaces entry in the Settings menu

Actual Result:

No red dot there

Workaround:

The user can use the app as normal, it is just bad feedback on where the error is.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[miljakljajic]

hey Aldo - I'm just going through your steps to try and reproduce, what does this mean?

Go offline with the incognito browser

How do I go offline on a specific browser window?

[trjExpensify]

I typically use like web/mobile, but you can open the JS console in the incognito browser > Network tab > then next to the wifi symbol switch the dropdown to Offline to follow the steps here:

[chiragsalian]

Once the PR is merged let's remember to also add regressions steps for QA to test this flow since I've told them to test RBR on settings -> workspaces if there is a member error. So it will be nice if they add this flow as well to their regression testing.

[JmillsExpensify]

+1000. Should we proactively open that issue back up?

[chiragsalian]

Which issue, the one to add QA regression steps? If so then no. I would rather create new issues to add QA steps to keep the process cleaner and easier to process through. Steps mentioned here.

[JmillsExpensify]

Cool, yeah I was referring to the previous one.

[aldo-expensify]

PR ready for review

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

• A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
• The PR that introduced the bug has been identified. Link to the PR:
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• Payment has been made to the issue reporter (if applicable)
• Payment has been made to the contributor that fixed the issue (if applicable)
• Payment has been made to the contributor+ that helped on the issue (if applicable)