Workspace - No #admins and #announce rooms after creating workspace

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to https://staging.new.epensify.com/
2. Sign in with expensifail account
3. Create new workspace
4. Return to LHN and look for #admins and #announce rooms

Expected Result:

#admins and #announce rooms are present after creating a workspace

Actual Result:

There are no #admins and #announce rooms after creating a workspace

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.12.2

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation=

Bug5768419_screen-20221008-205628.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[AndrewGable]

Asked internally if this was a change we made on purpose

[AndrewGable]

The answer is no, and it seems like this is a deploy blocker.

[ctkochan22]

Ah, looking

[ctkochan22]

hmm so it seems like when I delete the workspace "Unavailable workspaces" pop up

[tgolen]

I think those pop up because they have unread messages in them, which I think is what we want? Not sure.

[tgolen]

I'm going to pick this up this morning and start drafting a PR

Conclusion from slack thread:

Archived Chats

Access

• policyAdmins retain access to defaultRooms, userCreatedRooms & policyExpenseChats
• all chat participants retain access to policyExpenseChats
• If you have access to a chat, you should be able to search for it

Most Recent mode

• Shown in the LHN if you still have access to the chat when archived
• Not shown in the LHN when empty (I’m impartial about this filter personally, but I can see why we added it, as there is no reason at all you would possibly want an empty archived room in the LHN)

GSD Mode

• Shown in the LHN if active chat, unread or pinned if you haven’t lost access to the chat
• Not shown in the LHN when empty

[tgolen]

I'm making good progress on this. I have test cases which cover all the above logic. After lunch I will continue work on:

• cleaning up logic inside of isArchived() to remove this:

    if (!isChatRoom(report) && !isPolicyExpenseChat(report)) {
        return false;
    }

I need to go through all our code to ensure that it's not going to cause things to break