[HOLD for payment 2022-10-20] [$250] BUG: "A room with this name already exists" message appears saving room name without making any change

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to NewDot and login
2. Click on any room created
3. Tap the room name to see the details
4. In settings click "Save" for room name without making changes

Expected Result:

Nothing should happen

Actual Result:

"A room with this name already exists" message appears

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.11-2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
Issue reported by: @dangrous

Slack conversation:
https://expensify.slack.com/archives/C01GTK53T8Q/p1664923596295109

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[Puneet-here]

Proposal

We can add a new if statement for checking if the room name matches with current room name in validate method

App/src/pages/ReportSettingsPage.js

Line 96 in f710d78

validate() {

 if (this.state.newRoomName === this.props.report.reportName) {
            return false;
        }

[melvin-bot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.