[$250] Investigate: 💥 Crash 💥 `value`

[melvin-bot]

Firebase has reported a new crash that we need to fix, here are all the details we found:

Non-fatal Exception: JavaScriptError

Cannot set property 'bankName' of undefined

main.jsbundle:1710:2793 line 1710 value

Number of Crashes: 13

Device Information

• Platforms: iOS, Android
• App Versions: 1.2.11.1, 1.2.21-4, 1.2.25.0
• Devices: Apple iPhone10,1 15.6.1, Google sdk_gphone64_arm64 12, Apple iPhone14,2 16.0.2

Stacktraces

iOS 1.2.25.0

anonymous (/private/var/containers/Bundle/Application/7F77EEF4-9C23-4928-BFF2-5C55F8B84FA3/New Expensify.app/main.jsbundle:613:1068:613)
h (/private/var/containers/Bundle/Application/7F77EEF4-9C23-4928-BFF2-5C55F8B84FA3/New Expensify.app/main.jsbundle:2:1708:2)
d (/private/var/containers/Bundle/Application/7F77EEF4-9C23-4928-BFF2-5C55F8B84FA3/New Expensify.app/main.jsbundle:2:1151:2)
i (/private/var/containers/Bundle/Application/7F77EEF4-9C23-4928-BFF2-5C55F8B84FA3/New Expensify.app/main.jsbundle:2:497:2)
anonymous (/private/var/containers/Bundle/Application/7F77EEF4-9C23-4928-BFF2-5C55F8B84FA3/New Expensify.app/main.jsbundle:6:62:6)
h (/private/var/containers/Bundle/Application/7F77EEF4-9C23-4928-BFF2-5C55F8B84FA3/New Expensify.app/main.jsbundle:2:1708:2)
d (/private/var/containers/Bundle/Application/7F77EEF4-9C23-4928-BFF2-5C55F8B84FA3/New Expensify.app/main.jsbundle:2:1081:2)
i (/private/var/containers/Bundle/Application/7F77EEF4-9C23-4928-BFF2-5C55F8B84FA3/New Expensify.app/main.jsbundle:2:497:2)
global (/private/var/containers/Bundle/Application/7F77EEF4-9C23-4928-BFF2-5C55F8B84FA3/New Expensify.app/main.jsbundle:2935:4:2935)

iOS 1.2.25.0

anonymous (/private/var/containers/Bundle/Application/308D5C7E-5BCF-4157-A86E-EB3DD78B1915/New Expensify.app/main.jsbundle:613:960:613)
h (/private/var/containers/Bundle/Application/308D5C7E-5BCF-4157-A86E-EB3DD78B1915/New Expensify.app/main.jsbundle:2:1708:2)
d (/private/var/containers/Bundle/Application/308D5C7E-5BCF-4157-A86E-EB3DD78B1915/New Expensify.app/main.jsbundle:2:1151:2)
i (/private/var/containers/Bundle/Application/308D5C7E-5BCF-4157-A86E-EB3DD78B1915/New Expensify.app/main.jsbundle:2:497:2)
anonymous (/private/var/containers/Bundle/Application/308D5C7E-5BCF-4157-A86E-EB3DD78B1915/New Expensify.app/main.jsbundle:6:62:6)
h (/private/var/containers/Bundle/Application/308D5C7E-5BCF-4157-A86E-EB3DD78B1915/New Expensify.app/main.jsbundle:2:1708:2)
d (/private/var/containers/Bundle/Application/308D5C7E-5BCF-4157-A86E-EB3DD78B1915/New Expensify.app/main.jsbundle:2:1081:2)
i (/private/var/containers/Bundle/Application/308D5C7E-5BCF-4157-A86E-EB3DD78B1915/New Expensify.app/main.jsbundle:2:497:2)
global (/private/var/containers/Bundle/Application/308D5C7E-5BCF-4157-A86E-EB3DD78B1915/New Expensify.app/main.jsbundle:2935:4:2935)

iOS 1.2.25.0

anonymous (/private/var/containers/Bundle/Application/2FADF995-4C52-4B4C-A913-B655B3DBB419/New Expensify.app/main.jsbundle:613:954:613)
apply
anonymous (/private/var/containers/Bundle/Application/2FADF995-4C52-4B4C-A913-B655B3DBB419/New Expensify.app/main.jsbundle:77:1247:77)
k (/private/var/containers/Bundle/Application/2FADF995-4C52-4B4C-A913-B655B3DBB419/New Expensify.app/main.jsbundle:77:498:77)
callTimers (/private/var/containers/Bundle/Application/2FADF995-4C52-4B4C-A913-B655B3DBB419/New Expensify.app/main.jsbundle:77:2647:77)
apply
value (/private/var/containers/Bundle/Application/2FADF995-4C52-4B4C-A913-B655B3DBB419/New Expensify.app/main.jsbundle:42:3798:42)
anonymous (/private/var/containers/Bundle/Application/2FADF995-4C52-4B4C-A913-B655B3DBB419/New Expensify.app/main.jsbundle:42:674:42)
value (/private/var/containers/Bundle/Application/2FADF995-4C52-4B4C-A913-B655B3DBB419/New Expensify.app/main.jsbundle:42:2504:42)
value (/private/var/containers/Bundle/Application/2FADF995-4C52-4B4C-A913-B655B3DBB419/New Expensify.app/main.jsbundle:42:646:42)

Android 1.2.21-4

.anonymous
.loadModuleImplementation
.guardedLoadModule
.metroRequire
.global

iOS 1.2.11.1

value (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:1710:2793:1710)
value (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:1717:1909:1717)
value (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:1718:2862:1718)
anonymous (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:1724:1622:1724)
apply
o (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:51:151:51)
apply
h (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:51:294:51)
apply
g (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:51:348:51)
S (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:51:659:51)
Ne (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:51:14312:51)
call
Y (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:51:5341:51)
anonymous (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:51:14660:51)
Pe (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:51:99214:51)
Ce (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:51:14122:51)
Le (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:51:14499:51)
receiveEvent (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:51:14915:51)
apply
value (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:42:3798:42)
anonymous (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:42:674:42)
value (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:42:2504:42)
value (/private/var/containers/Bundle/Application/625CC88E-B95F-477C-856B-E75C0570A328/New Expensify.app/main.jsbundle:42:646:42)

---

Internal Firebase Info

💥 DO NOT EDIT THIS SECTION 💥

Crash IDs: fd1cdb4e916b7497e85f0e22ad937c6e, 29f5a4afa1f0968901244363906bf119, 0c9127e6df526e091a2c1234b473af9b, 2b58bfd50d223d37654eb072cb29246c, 54fb4089ec2c2c6eade240626fb36962
Exception: Cannot set property 'bankName' of undefined

REMINDER: Typically, Firebase Crashlytics issues should be capped at $500.

[melvin-bot]

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @sketchydroide (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[nonamebmt94]

Proposal:
This constant can be returned undefined so it cannot be set a value.
const selectedPlaidBankAccount = _.findWhere(this.getPlaidBankAccounts(), {plaidAccountID});

Solution:
Check undefined before set value.

App/src/components/AddPlaidBankAccount.js

Lines 118 to 120 in 18fcaf4

	const selectedPlaidBankAccount = _.findWhere(this.getPlaidBankAccounts(), {plaidAccountID});
	selectedPlaidBankAccount.bankName = this.props.plaidData.bankName;
	selectedPlaidBankAccount.plaidAccessToken = this.props.plaidData.plaidAccessToken;

[sketchydroide]

I think we need a bit more than that @nonamebmt94, sure that fixes the crash, but then we are selecting an undefined bank account, I think that will create more issues than the line.
An a front facing error to the user, and maybe a return ealy instead would be more useful

What are you thoughts @eVoloshchak?

[eVoloshchak]

What are you thoughts @eVoloshchak?

I think you are definitely right about the early return since we might have problems when passing undefined to this.props.onSelect

I personally feel like showing the user an error would be the way to go, but I don't know what's the policy on that, do we need to show alert on every error or some of them can be silent?

But my main question is:
Why is it even possible to select a bank account that doesn't exist?
Looking at the code, options for the picker and the list of accounts when one of them is selected come from one place - getPlaidBankAccounts, so this shouldn't happen

@nonamebmt94, did you decode the sourcemaps and verified that the error happening on main.jsbundle:1710:2793 line 1710 is indeed the selectAccount method?

[sketchydroide]

Why is it even possible to select a bank account that doesn't exist?
Looking at the code, options for the picker and the list of accounts when one of them is selected come from one place - getPlaidBankAccounts, so this shouldn't happen

This is a question I would like to dig into as well, if that has an easy answer then it is the preferable solution.
If not then the early return with the message to the user.

I think that any CTO that the user interacts with should have a reaction, in this case if the user chooses an account then either an account should be selected or a message to the user should be given.

[nonamebmt94]

I think we need a bit more than that @nonamebmt94, sure that fixes the crash, but then we are selecting an undefined bank account, I think that will create more issues than the line.
An a front facing error to the user, and maybe a return ealy instead would be more useful

@eVoloshchak @sketchydroide Thank you for your feedback. I could go deeper and tell you what happened but for that, I think I can help a bit. Can you help me with some documentation about this feature and a test account that has Plaid Bank Accounts? Right now, I just fixed it with my assumption and dummy data I generated based on the DTO in the app.