Skip to content

[Due for payment 2026-10-28] [Insights][R2][App] Draw multi-series bar charts #103769

Closed

Description

@MelvinBot

Sub-issue of #100664, created to track the work for this part separately.

Design doc section: https://docs.google.com/document/d/1w3bjKnKt_yzulhzRko6wwejySVvqB2tHkFWJn1O5h7w/edit?tab=t.0#heading=h.43vgst99f277

Requested in #101874

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. changed the title [-][Insights][R2][App] Draw multi-series bar charts[/-] [+][Due for payment 2026-10-28] [Insights][R2][App] Draw multi-series bar charts[/+] on Oct 21, 2026
  2. 1 remaining item

  3. truph01 commented on Oct 23, 2026

    @truph01
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR:
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Test:

    1. Enable the insightsPage and insightsCompare betas. Go to Insights and set Date to This month and Compare to Average. Verify that Top spenders and Top merchants show two bars per group: the current one, and a lighter shade of the same color next to it.
    2. Hover over a bar on desktop web, or tap it on other platforms. Verify that the tooltip shows the amount, "Typical: [amount]", and the change with an arrow and percentage.
    3. Verify that Top categories shows grouped bars instead of a pie. Set Compare to None and verify that the pie returns.
    4. With Compare set to Average, verify that each table row under the bar charts shows a red up arrow or a green down arrow with the change percentage, and that rows with equal amounts show none.
    5. Pick a range where Spend over time has a single point and set Compare to Average. Verify that it's drawn as two bars: the current amount and the Average.
    6. Set Compare to Previous period. Verify that the tooltip names the bars by the current and previous month, like "October 2026" and "September 2026".
    7. Set Date to Year to date. Verify that the bars are named by the dates from January 1 to today, this year and last year, like "Jan 1 - Oct 15, 2026" and "Jan 1 - Oct 15, 2025".
    8. Set a custom Date range of October 1 to October 31, 2026. Verify that the bars are named "October 2026" and "Aug 31 - Sep 30, 2026
    9. Set Date to This month and add an expense dated the last day of the month before last. Verify that it isn't counted in the previous period.
    10. Set Date to a single day, October 10, 2026. Verify that the bars are named "Oct 10, 2026" and "Oct 9, 2026".
    11. Switch to dark mode and verify that the compared bars and tooltip dots use the darker shade of each bar's hue.
    12. Set Compare to None and verify that all charts look as they did before this change.

    Do we agree 👍 or 👎

  4. truph01 commented on Oct 23, 2026

    @truph01
    Contributor

    This is part of https://github.com/orgs/Expensify/projects/317. As we can see, a few completed issues were paid at the old rate of $250.

  5. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 27, 2026
  6. melvin-bot commented on Oct 27, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  7. melvin-bot commented on Oct 27, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  8. mallenexpensify commented on Oct 30, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @truph01 due $250 via NewDot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions