You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-28] [Insights][R2][App] Draw multi-series bar charts #103769
changed the title [-][Insights][R2][App] Draw multi-series bar charts[/-][+][Due for payment 2026-10-28] [Insights][R2][App] Draw multi-series bar charts[/+]on Oct 21, 2026
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR:
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Enable the insightsPage and insightsCompare betas. Go to Insights and set Date to This month and Compare to Average. Verify that Top spenders and Top merchants show two bars per group: the current one, and a lighter shade of the same color next to it.
Hover over a bar on desktop web, or tap it on other platforms. Verify that the tooltip shows the amount, "Typical: [amount]", and the change with an arrow and percentage.
Verify that Top categories shows grouped bars instead of a pie. Set Compare to None and verify that the pie returns.
With Compare set to Average, verify that each table row under the bar charts shows a red up arrow or a green down arrow with the change percentage, and that rows with equal amounts show none.
Pick a range where Spend over time has a single point and set Compare to Average. Verify that it's drawn as two bars: the current amount and the Average.
Set Compare to Previous period. Verify that the tooltip names the bars by the current and previous month, like "October 2026" and "September 2026".
Set Date to Year to date. Verify that the bars are named by the dates from January 1 to today, this year and last year, like "Jan 1 - Oct 15, 2026" and "Jan 1 - Oct 15, 2025".
Set a custom Date range of October 1 to October 31, 2026. Verify that the bars are named "October 2026" and "Aug 31 - Sep 30, 2026
Set Date to This month and add an expense dated the last day of the month before last. Verify that it isn't counted in the previous period.
Set Date to a single day, October 10, 2026. Verify that the bars are named "Oct 10, 2026" and "Oct 9, 2026".
Switch to dark mode and verify that the compared bars and tooltip dots use the darker shade of each bar's hue.
Set Compare to None and verify that all charts look as they did before this change.
Activity
[-][Insights][R2][App] Draw multi-series bar charts[/-][+][Due for payment 2026-10-28] [Insights][R2][App] Draw multi-series bar charts[/+]1 remaining item
truph01 commentedon Oct 23, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR:
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
insightsPageandinsightsComparebetas. Go to Insights and set Date to This month and Compare to Average. Verify that Top spenders and Top merchants show two bars per group: the current one, and a lighter shade of the same color next to it.Do we agree 👍 or 👎
truph01 commentedon Oct 23, 2026
This is part of https://github.com/orgs/Expensify/projects/317. As we can see, a few completed issues were paid at the old rate of $250.
melvin-bot commentedon Oct 27, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Oct 27, 2026
Payment Summary
Resolving PRs:
[NoQA] [Insights] Draw multi-series bar charts #104085
Contributor: @mhawryluk does not require payment (Contractor)
Reviewer: @truph01 owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Oct 30, 2026
Payment Summary
Contributor+: @truph01 due $250 via NewDot