Skip to content

[Due for payment 2026-10-16] Payment issue for E/App PR#101422 #103657

Open

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #101422
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/682002.
Contributor+ member who reviewed the PR - @FitseTLT.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @FitseTLT

Activity

  1. melvin-bot commented on Oct 9, 2026

    @melvin-bot
    Author

    @FitseTLT The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. melvin-bot commented on Oct 12, 2026

    @melvin-bot
    Author

    @FitseTLT Whoops! This issue is 2 days overdue. Let's get this updated quick!

  3. FitseTLT commented on Oct 13, 2026

    @FitseTLT
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: https://github.com/Expensify/App/pull/85575/changes#r4258554750
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A — not critical. The approval limit is one optional column of the member CSV import; the core import flow still completed, and the imported value was visibly wrong rather than silently destructive.

    Regression Test Proposal

    Precondition:

    • A Collect or Control workspace where the admin can import members from a spreadsheet.
    • The workspace currency is set to USD.

    Test:

    1. Create a CSV with the columns Email, Approval limit and Over limit forward to, and one member row with an Approval limit of 500.
    2. Go to Workspace settings > Members > Import spreadsheet and upload the CSV.
    3. Map the columns to Email, Approval limit and Over limit forward to, then confirm the import.
    4. Open the imported member's details and verify the approval limit shows $500, not $5.
    5. Repeat the import with the approval limit written as $1,234.56 and verify it is accepted and shows $1,234.56.
    6. Repeat the import with the approval limit written as abc and verify the import is blocked with the error "Approval limits must be valid amounts for the workspace currency."

    Do we agree 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions