You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-16] Payment issue for E/App PR#101422 #103657
@FitseTLT The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A — not critical. The approval limit is one optional column of the member CSV import; the core import flow still completed, and the imported value was visibly wrong rather than silently destructive.
Regression Test Proposal
Precondition:
A Collect or Control workspace where the admin can import members from a spreadsheet.
The workspace currency is set to USD.
Test:
Create a CSV with the columns Email, Approval limit and Over limit forward to, and one member row with an Approval limit of 500.
Go to Workspace settings > Members > Import spreadsheet and upload the CSV.
Map the columns to Email, Approval limit and Over limit forward to, then confirm the import.
Open the imported member's details and verify the approval limit shows $500, not $5.
Repeat the import with the approval limit written as $1,234.56 and verify it is accepted and shows $1,234.56.
Repeat the import with the approval limit written as abc and verify the import is blocked with the error "Approval limits must be valid amounts for the workspace currency."
Activity
melvin-bot commentedon Oct 9, 2026
@FitseTLT The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Oct 12, 2026
@FitseTLT Whoops! This issue is 2 days overdue. Let's get this updated quick!
FitseTLT commentedon Oct 13, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: https://github.com/Expensify/App/pull/85575/changes#r4258554750
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A — not critical. The approval limit is one optional column of the member CSV import; the core import flow still completed, and the imported value was visibly wrong rather than silently destructive.
Regression Test Proposal
Precondition:
Test:
Email,Approval limitandOver limit forward to, and one member row with anApproval limitof500.Email,Approval limitandOver limit forward to, then confirm the import.$1,234.56and verify it is accepted and shows $1,234.56.abcand verify the import is blocked with the error "Approval limits must be valid amounts for the workspace currency."Do we agree 👍 or 👎