Repository navigation
[Due for payment 2026-10-16] Skip Search auto-refetch diff when transactions are unchanged #103443
Description
Problem
useSearchAutoRefetch re-runs its effect on snapshot, loading, and focus changes. By then usePrevious has already caught up, so the effect diffs the full transaction collection against itself and always finds nothing. hasChangedTransactionInSearchResults also calls Object.entries(transactions) a second time, which allocates a pair for every transaction. Together these cost about 120ms per trace on a large account.
Solution
The effect now returns early when transactions and reportActions are the same references as the previous ones and no search is pending. This keeps behavior the same, because every check already evaluated to false in that case. hasChangedTransactionInSearchResults now loops over the transactionsIDs array the effect already computed. Its total time dropped from 120ms to 11ms, and ManualOpenReport dropped about 210ms (about 5%).
PR
Issue Owner
Current Issue Owner: @mallenexpensifyMetadata
Metadata
Type
Projects
- Status
Activity
[-]Skip Search auto-refetch diff when transactions are unchanged[/-][+][Due for payment 2026-10-16] Skip Search auto-refetch diff when transactions are unchanged[/+]melvin-bot commentedon Oct 9, 2026
@nkdengineer
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.6-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-16. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Oct 12, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)nkdengineer commentedon Oct 12, 2026
This is a performance issue, so there is no need for a checklist here.
melvin-bot commentedon Oct 15, 2026
Payment Summary
Resolving PRs:
Skip Search auto-refetch diff when transactions are unchanged #103436
Contributor: @TMisiukiewicz does not require payment (Contractor)
Reviewer: @nkdengineer owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
melvin-bot commentedon Oct 15, 2026
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!