Skip to content

Expense - Category list opens instead of pop-over when submitting to employer #103125

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.3-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #102665
Email or phone of affected tester (no customers): jsoidjndoiniodnsjojd@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Enable anchoredFieldDropdowns
  • Account has no workspace.
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Create an expense.
  4. Click Submit to my employer.
  5. Click Category.

Expected Result:

Category pop-over will open.

Actual Result:

Category list opens when submitting to employer.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7278366_1791246862847.14.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7278366

Activity

  1. applause-bot commented on Oct 6, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/d21bbe33398bbe30c1c84e7b051ab848d5227115286bf5c4ba8680825bd307f9

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 6, 2026
  3. melvin-bot commented on Oct 6, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #102665

  4. melvin-bot commented on Oct 6, 2026

    @melvin-bot

    @puneetlath @ikevin127 you have been assigned to this deploy blocker because you reviewed the offending PR: #102665

  5. github-actions commented on Oct 6, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Oct 6, 2026

    @melvin-bot

    @DylanDylann you have been assigned to this deploy blocker because you authored the offending PR: #102665

  7. melvin-bot commented on Oct 6, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Oct 6, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Causing PR: [CFI] Open the Category list in a container anchored to its row (high confidence)

    Recommendation: demote and fix forward. No revert needed. Nothing that works in production is broken. Before this PR, the Category row always opened the full-page list, and in this flow it still does. The pop-over is behind the anchoredFieldDropdowns beta, and the fix is small.

    Root cause: For an account with no workspace, "Submit to my employer" creates a draft workspace. Its categories are stored only under POLICY_CATEGORIES_DRAFT. The new pop-over check in CategoryField.tsx:72 reads only POLICY_CATEGORIES. That sets hasEnabledCategories to false and shouldOpenInDropdown to false (CategoryField.tsx:154-155). The tap then falls back to the full-page list.

    Recommended fix: In the three places the PR reads only the real key, also read POLICY_CATEGORIES_DRAFT and use real ?? draft. usePolicyCategoriesForConfirmation.ts:12-16 already does this.

    1. CategoryField.tsx:72. This one causes the bug.
    2. CategoryFieldDropdown.tsx:42, so violations are checked against the draft list.
    3. CategoryPickerModal.tsx:75, so the pop-over gets the right size.

    Related: Expense - Category list opens instead of pop-over after upgrading workspace has the same symptom and the same causing PR. Check it with this fix.

    Investigation details
    1. "Submit to my employer" with no workspace calls createDraftWorkspaceAndNavigateToConfirmationScreen (StartExpenseFlows.ts:381-400).
    2. createDraftWorkspace writes the workspace and its default categories only to POLICY_DRAFTS and POLICY_CATEGORIES_DRAFT (Policy.ts:3170-3237).
    3. The other pop-over conditions pass:
    4. Only hasEnabledCategories fails, because nothing exists under POLICY_CATEGORIES<draftPolicyID>.
    5. The full page still shows categories because it already falls back to the draft list (DynamicIOURequestStepCategory.tsx:89-92, CategoryPicker/index.tsx:81-82).

    The PR's test steps used only an existing workspace that already had categories, so this draft-workspace path was not covered. This analysis comes from reading the code. I did not reproduce it in the app.


    Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.


    view run

  9. 10 remaining items

  10. ikevin127 commented on Oct 13, 2026

    @ikevin127
    Contributor

    There are quite a few follow-ups to be deployed so payment not due yet.

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 13, 2026
  12. melvin-bot commented on Oct 19, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  13. melvin-bot commented on Oct 19, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  14. changed the title [-][Due for payment 2026-10-20] Expense - Category list opens instead of pop-over when submitting to employer[/-] [+]Expense - Category list opens instead of pop-over when submitting to employer[/+] on Oct 20, 2026
  15. removed their assignment
    on Oct 20, 2026
  16. mallenexpensify commented on Oct 20, 2026

    @mallenexpensify
    Contributor

    Please comment and tag me if/when payment is due, thx

  17. melvin-bot commented on Oct 20, 2026

    @melvin-bot

    @puneetlath @ikevin127 @DylanDylann this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions