You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Category list opens instead of pop-over when submitting to employer #103125
Version Number: 9.5.3-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#102665 Email or phone of affected tester (no customers):jsoidjndoiniodnsjojd@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Recommendation: demote and fix forward. No revert needed. Nothing that works in production is broken. Before this PR, the Category row always opened the full-page list, and in this flow it still does. The pop-over is behind the anchoredFieldDropdowns beta, and the fix is small.
Root cause: For an account with no workspace, "Submit to my employer" creates a draft workspace. Its categories are stored only under POLICY_CATEGORIES_DRAFT. The new pop-over check in CategoryField.tsx:72 reads only POLICY_CATEGORIES. That sets hasEnabledCategories to false and shouldOpenInDropdown to false (CategoryField.tsx:154-155). The tap then falls back to the full-page list.
Recommended fix: In the three places the PR reads only the real key, also read POLICY_CATEGORIES_DRAFT and use real ?? draft. usePolicyCategoriesForConfirmation.ts:12-16 already does this.
The PR's test steps used only an existing workspace that already had categories, so this draft-workspace path was not covered. This analysis comes from reading the code. I did not reproduce it in the app.
Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.
changed the title [-][Due for payment 2026-10-20] Expense - Category list opens instead of pop-over when submitting to employer[/-][+]Expense - Category list opens instead of pop-over when submitting to employer[/+]on Oct 20, 2026
@puneetlath @ikevin127 @DylanDylann this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Activity
applause-bot commentedon Oct 6, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/d21bbe33398bbe30c1c84e7b051ab848d5227115286bf5c4ba8680825bd307f9
melvin-bot commentedon Oct 6, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #102665
melvin-bot commentedon Oct 6, 2026
@puneetlath @ikevin127 you have been assigned to this deploy blocker because you reviewed the offending PR: #102665
github-actions commentedon Oct 6, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 6, 2026
@DylanDylann you have been assigned to this deploy blocker because you authored the offending PR: #102665
melvin-bot commentedon Oct 6, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Oct 6, 2026
Deploy Blocker Analysis
Causing PR: [CFI] Open the Category list in a container anchored to its row (high confidence)
Recommendation: demote and fix forward. No revert needed. Nothing that works in production is broken. Before this PR, the Category row always opened the full-page list, and in this flow it still does. The pop-over is behind the
anchoredFieldDropdownsbeta, and the fix is small.Root cause: For an account with no workspace, "Submit to my employer" creates a draft workspace. Its categories are stored only under
POLICY_CATEGORIES_DRAFT. The new pop-over check in CategoryField.tsx:72 reads onlyPOLICY_CATEGORIES. That setshasEnabledCategoriesto false andshouldOpenInDropdownto false (CategoryField.tsx:154-155). The tap then falls back to the full-page list.Recommended fix: In the three places the PR reads only the real key, also read
POLICY_CATEGORIES_DRAFTand usereal ?? draft. usePolicyCategoriesForConfirmation.ts:12-16 already does this.Related: Expense - Category list opens instead of pop-over after upgrading workspace has the same symptom and the same causing PR. Check it with this fix.
Investigation details
createDraftWorkspaceAndNavigateToConfirmationScreen(StartExpenseFlows.ts:381-400).createDraftWorkspacewrites the workspace and its default categories only toPOLICY_DRAFTSandPOLICY_CATEGORIES_DRAFT(Policy.ts:3170-3237).policyfalls back to the draft workspace (usePolicyForTransaction.ts:57-68).shouldNavigateToUpgradePathis false for Submit workspaces (useFooterDerivedFlags.ts:99-101).shouldSelectPolicyis false with no workspace (usePolicyForMovingExpenses.ts:114-116).hasEnabledCategoriesfails, because nothing exists underPOLICY_CATEGORIES<draftPolicyID>.The PR's test steps used only an existing workspace that already had categories, so this draft-workspace path was not covered. This analysis comes from reading the code. I did not reproduce it in the app.
Next Steps: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.view run
10 remaining items
ikevin127 commentedon Oct 13, 2026
There are quite a few follow-ups to be deployed so payment not due yet.
melvin-bot commentedon Oct 19, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Oct 19, 2026
Payment Summary
Resolving PRs:
Fix: Category list opens instead of pop-over #103153
Reviewer: @ikevin127 owed $175 via NewDot
Reviewer: @DylanDylann owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
[-][Due for payment 2026-10-20] Expense - Category list opens instead of pop-over when submitting to employer[/-][+]Expense - Category list opens instead of pop-over when submitting to employer[/+]mallenexpensify commentedon Oct 20, 2026
Please comment and tag me if/when payment is due, thx
melvin-bot commentedon Oct 20, 2026
@puneetlath @ikevin127 @DylanDylann this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!