Skip to content

[Due for payment 2026-10-16] Expense - View link on growl is not underlined in high contrast mode #102889

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.1-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #100015
Email or phone of affected tester (no customers): jsoidjndoiniodnsjojd@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Enable high contrast mode in Account > Preferences > Theme.
  1. Go to staging.new.expensify.com
  2. Open FAB > Create expense > Manual.
  3. Create an expense.

Expected Result:

View link on growl will be underlined in high contrast mode.

Actual Result:

View link on growl is not underlined in high contrast mode.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7275183_1790945278480.Screen_Recording_2026-10-02_at_20.32.16.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7275183

Issue OwnerCurrent Issue Owner: @situchan

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 2, 2026
  2. applause-bot commented on Oct 2, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/7b2d3d59219f8e7f7a542c20ea42c8de0f307198b333f58b570455ce9e6ab137

  3. melvin-bot commented on Oct 2, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #100015

  4. github-actions commented on Oct 2, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 2, 2026

    @melvin-bot

    @mountiny @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #100015

  6. melvin-bot commented on Oct 2, 2026

    @melvin-bot

    @mhawryluk you have been assigned to this deploy blocker because you authored the offending PR: #100015

  7. melvin-bot commented on Oct 2, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 2, 2026
  9. MelvinBot commented on Oct 2, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Causing PR: Confirm new expenses with a “View” toast instead of scrolling to and highlighting the row v2. The auto-assignment is correct.

    Recommendation: Demote this from deploy blocker and fix it with a follow-up PR. Don't revert. This is a missing piece of a new feature, not a regression. The "View" button still works. Reverting would remove the whole growl feature over a missing underline.

    Root cause: The growl's "View" action is a Button, not a link. Its text style sets only a color, so it never gets the high contrast underline that the shared link style applies.

    Fix: Add one line to growlNotificationActionText in src/styles/index.ts:3688-3690:

    growlNotificationActionText: {
        color: theme.linkReversed,
        textDecorationLine: theme.isHighContrast ? 'underline' : 'none',
    },

    Design should confirm that a link-styled text button should follow the high contrast link rule.

    Investigation details

    Confidence: High that the v2 PR exposed the bug. Medium that it introduced the bug, since the style most likely came from the earlier attempt.


    Next Steps: An internal engineer should decide whether to demote this blocker. Reply with @MelvinBot implement this to create a draft PR with the fix.

  10. changed the title [-]Expense - View link on growl is not underlined in high contrast mode[/-] [+][Due for payment 2026-10-16] Expense - View link on growl is not underlined in high contrast mode[/+] on Oct 9, 2026
  11. melvin-bot commented on Oct 9, 2026

    @melvin-bot

    @situchan

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.6-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-10-16. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions