You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-16] Expense - View link on growl is not underlined in high contrast mode #102889
Version Number: 9.5.1-2 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#100015 Email or phone of affected tester (no customers):jsoidjndoiniodnsjojd@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Enable high contrast mode in Account > Preferences > Theme.
Go to staging.new.expensify.com
Open FAB > Create expense > Manual.
Create an expense.
Expected Result:
View link on growl will be underlined in high contrast mode.
Actual Result:
View link on growl is not underlined in high contrast mode.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Recommendation: Demote this from deploy blocker and fix it with a follow-up PR. Don't revert. This is a missing piece of a new feature, not a regression. The "View" button still works. Reverting would remove the whole growl feature over a missing underline.
Root cause: The growl's "View" action is a Button, not a link. Its text style sets only a color, so it never gets the high contrast underline that the shared link style applies.
The PR adds ExpenseAddedGrowl, which shows the growl with a "View" action after an expense is created: ExpenseAddedGrowl.tsx:156-162. This is the first time users can see a growl action.
changed the title [-]Expense - View link on growl is not underlined in high contrast mode[/-][+][Due for payment 2026-10-16] Expense - View link on growl is not underlined in high contrast mode[/+]on Oct 9, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.6-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-16. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Oct 2, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/7b2d3d59219f8e7f7a542c20ea42c8de0f307198b333f58b570455ce9e6ab137
melvin-bot commentedon Oct 2, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #100015
github-actions commentedon Oct 2, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 2, 2026
@mountiny @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #100015
melvin-bot commentedon Oct 2, 2026
@mhawryluk you have been assigned to this deploy blocker because you authored the offending PR: #100015
melvin-bot commentedon Oct 2, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Oct 2, 2026
Deploy Blocker Analysis
Causing PR: Confirm new expenses with a “View” toast instead of scrolling to and highlighting the row v2. The auto-assignment is correct.
Recommendation: Demote this from deploy blocker and fix it with a follow-up PR. Don't revert. This is a missing piece of a new feature, not a regression. The "View" button still works. Reverting would remove the whole growl feature over a missing underline.
Root cause: The growl's "View" action is a
Button, not a link. Its text style sets only a color, so it never gets the high contrast underline that the sharedlinkstyle applies.Fix: Add one line to
growlNotificationActionTextin src/styles/index.ts:3688-3690:Design should confirm that a link-styled text button should follow the high contrast link rule.
Investigation details
linkandemailLinkstyles add the underline only in high contrast mode: src/styles/index.ts:168-188.styles.growlNotificationActionTextinside a transparentButton: GrowlNotificationContent.tsx:159-173.ExpenseAddedGrowl, which shows the growl with a "View" action after an expense is created: ExpenseAddedGrowl.tsx:156-162. This is the first time users can see a growl action.Confidence: High that the v2 PR exposed the bug. Medium that it introduced the bug, since the style most likely came from the earlier attempt.
Next Steps: An internal engineer should decide whether to demote this blocker. Reply with
@MelvinBot implement thisto create a draft PR with the fix.[-]Expense - View link on growl is not underlined in high contrast mode[/-][+][Due for payment 2026-10-16] Expense - View link on growl is not underlined in high contrast mode[/+]melvin-bot commentedon Oct 9, 2026
@situchan
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.6-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-16. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]