Repository navigation
[Due for payment 2026-10-07] Expense - Floating RHP closes after clicking on the top area within the RHP #102622
Description
If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.
Version Number: 9.4.97-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #101093
Email or phone of affected tester (no customers): jsdoijnodsdisojo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests
Action Performed:
- Go to staging.new.expensify.com
- Go to workspace chat.
- Create an expense.
- Open the report.
- Click on the area above Submit button within the floating RHP.
Expected Result:
Floating RHP will not close after clicking on the top area within the RHP.
Actual Result:
Floating RHP closes after clicking on the top area within the RHP.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome Safari
Screenshots/Videos
To be added by Applause Leads
Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7273157
Issue Owner
Current Issue Owner: @huultMetadata
Metadata
Assignees
Type
Projects
- Status
Activity
applause-bot commentedon Sep 30, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/c7ef74440b4f643934cca1fa9e89648a84fd50943bfb4690baca98ff21c18837
melvin-bot commentedon Sep 30, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #101093
melvin-bot commentedon Sep 30, 2026
@mountiny @huult you have been assigned to this deploy blocker because you reviewed the offending PR: #101093
melvin-bot commentedon Sep 30, 2026
@BartekObudzinski you have been assigned to this deploy blocker because you authored the offending PR: #101093
melvin-bot commentedon Sep 30, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Sep 30, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Sep 30, 2026
Deploy Blocker Analysis
Causing PR: feat: use floating RHP style on web (
Expensify/App#101093). Confidence: high (confirmed from code, not reproduced in a browser).Root cause: The PR adds three transparent overlay bands around the floating card. The top band is only 12px tall, but it reuses
BaseOverlay, which has a fixed 30px click target inside it. Nothing clips that target, so a close-on-click strip covers about 18px of the card's top edge. Clicking there callsnavigation.goBack()and closes the RHP.Recommended fix (roll forward): Add
styles.overflowHiddento the rootAnimated.Viewstyle in BaseOverlay.tsx:63-67. This clips the click target to the 12px band. If a fix can't land quickly, reverting the PR is a clean fallback.Investigation details
shouldUseCenteredFrameis true (a wide report or expense in the RHP), which is why the report flow triggers it.top: 0andpositionBottomValue = windowHeight - 12(L213, L580), so it is 12px tall.BaseOverlay's first child is aPressableWithoutFeedbackwithstyles.draggableTopBar(height: 30): BaseOverlay.tsx:74-81, styles/index.ts:5496-5499.top: 12(styles/index.ts:89), so y = 12–30px across the card is a hidden click target.handleFloatingCardGapPress→handleOverlayPress→navigation.goBack()(L240-L262).The bottom band overflows too, but below the viewport, so it's harmless. None of the other 45 PRs in Deploy Checklist: New Expensify 2026-09-30 touch RHP navigation, overlays, or card styles.
An alternative fix is to give
RHPOverlayan option that renders one full-size click target without the 30px drag bar, and use it for the three gap bands.Next Steps: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.view run
BartekObudzinski commentedon Sep 30, 2026
I will check it
BartekObudzinski commentedon Sep 30, 2026
pr ready to review #102638
IuliiaHerets commentedon Sep 30, 2026
Chrome / v9.4.99-0
Passed
bandicam.2026-09-30.21-01-56-254.mp4
[-]Expense - Floating RHP closes after clicking on the top area within the RHP[/-][+][Due for payment 2026-10-07] Expense - Floating RHP closes after clicking on the top area within the RHP[/+]melvin-bot commentedon Sep 30, 2026
@huult
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.99-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-07. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]