[Due for payment 2026-09-08] [iOS] Crash when duplicating more than 15 reports with 50+ expenses

[luacmartins]

Problem

On iOS, duplicating more than 15 reports containing 50+ expenses each crashes app.

Related issue: #98970

Why is this important?

Large batch report duplication crashes iOS app. Root cause differs from crash reported on web in #98970.

Solution

Patch React Native RCTViewComponentView to resolve currentContainerView before reading child superview in unmountChildComponentView:index:. Reading currentContainerView can migrate existing subviews when custom container usage changes, making assertion compare hierarchy from different states.

Reproduction

Precondition: create several reports with 50+ expenses each.

1. Open staging.new.expensify on iOS.
2. Go to Spend > Reports.
3. Select more than 15 prepared reports.
4. Duplicate reports.

Expected: reports duplicate.

Actual: iOS app crashes.

Context: https://expensify.slack.com/archives/C01GTK53T8Q/p1788247737403139

cc @mukhrr @nkdengineer

Issue Owner

Current Issue Owner: @mallenexpensify

Issue Owner

Current Issue Owner: @mukhrr

[nkdengineer]

@luacmartins please assign me.

[mukhrr]

me too pls)

[mukhrr]

@nkdengineer fyi:

RCA

-[RCTViewComponentView unmountChildComponentView:index:] asserts:

RCTAssert(childComponentView.superview == self.currentContainerView, ...)

currentContainerView is not a pure getter. When _useCustomContainerView flips it creates or tears down _containerView and moves the existing subviews across (RCTViewComponentView.mm:975-1005). So reading it mutates the very hierarchy the assertion is checking, and the two operands of == are unsequenced in C++ — superview can be read before the migration runs, then compared against the post-migration container.

The tell is in the crash message: existing parent equals the parent's own tag. The child really is inside the parent, just not inside the parent's container view. [childComponentView removeFromSuperview] immediately after works fine, which is why nothing renders wrong.

_useCustomContainerView is recomputed on every finalizeUpdates from styleWouldClipOverflowInk (overflow: hidden plus a shadow, border, or outline), so any view crossing that threshold with mounted children is exposed.

Solution

Resolve the container once, before superview is read, as a patch in patches/react-native/:

+    UIView *containerView = self.currentContainerView;
     RCTAssert(
-        childComponentView.superview == self.currentContainerView,
+        childComponentView.superview == containerView,

[IuliiaHerets]

iPhone 17 Pro Max
v9.4.72-2
not repro

ScreenRecording_09-07-2026.10-09-29_1.MP4

[mukhrr]

@luacmartins I closed PR per

iPhone 17 Pro Max v9.4.72-2 not repro

ScreenRecording_09-07-2026.10-09-29_1.MP4

and I am curios if we are still available to be paid since we put some effort here? cc @mallenexpensify @nkdengineer