Skip to content

fix(ce-code-review): clarify Stage 4 asset reads - #1848

Merged
tmchow merged 2 commits into
EveryInc:mainfrom
SomSamantray:fix/1830-stage4-file-reads
Oct 11, 2026
Merged

tmchow merged 2 commits into
EveryInc:mainfrom
SomSamantray:fix/1830-stage4-file-reads

Conversation

@SomSamantray

Copy link
Copy Markdown
Contributor

Stage 4 now tells reviewers to read each dispatch asset separately, keeping large reference files from being concatenated into truncated shell output.

Fixes #1830

Validation

  • Focused regression guard passed.
  • bun run test:skill-guards passed.
  • bun run test passed (4,517 passed, 10 skipped).
  • bun run typecheck passed.
  • bun run release:validate passed.
  • Fresh Codex skill eval passed. Claude is unavailable in this environment; the September review trace documents the baseline failure.
  • Browser validation was not required because no page sources changed.

Security Disclosure

No security-relevant changes.

Agent Disclosure

  • Model: Codex CLI · GPT-6

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-10T11:51:51.231871Z 79f36af PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tmchow

tmchow commented Oct 11, 2026

Copy link
Copy Markdown
Collaborator

Thanks @SomSamantray, the diagnosis is right and the prose change reads well. I left it as-is.

I pushed one commit (20c2677) that trims the new test. It had four regexes, each matching a whole sentence of the new instruction. I cut it to one pin on "never join files into one shell output". That's the condition that actually fixes #1830, and it fails against the old "one parallel read-tool wave" text. The other three pinned wording, so any rewording later would break the test without the behavior changing. We try to pin the smallest thing that goes red on the regression. I also dropped the comment pointing at the issue, since the commit history already carries that.

Full suite, typecheck, and skill guards pass locally.

@tmchow
tmchow merged commit 62ff8a7 into EveryInc:main Oct 11, 2026
8 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ce-code-review: Stage 4 "one parallel read-tool wave" leads to a truncated cat and about 10 wasted orchestrator turns

2 participants