Load VS extension for all SQL scripts#576
Conversation
There was a problem hiding this comment.
⚠️ Not ready to approve
The new activation constraints can prevent the extension (and its command contributions) from loading when a SQL project is active but no SQL editor is open, causing a functional regression.
Pull request overview
This PR updates the Visual Studio (VSIX) extension activation logic so the extension loads based on the active editor’s SQL content type, rather than only when a SQL project is active (SqlProj / Microsoft.Build.Sql / classic .sqlproj).
Changes:
- Replaced project-capability/build-property activation constraints with editor content-type activation constraints (
SQL,SQL Server Tools).
File summaries
| File | Description |
|---|---|
| tools/SqlAnalyzerVsix/SqlAnalyzerExtension.cs | Changes when the VSIX extension loads by switching from project-based to editor content-type-based activation. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
There was a problem hiding this comment.
⚠️ Not ready to approve
The new hard-coded Sql170 fallback can change behavior and potentially break command execution for users whose installed analyzer CLI/tooling defaults to (or only supports) Sql160.
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
No description provided.