Fix launch bug#574
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates how the VSIX extension launches the SQL analyzer process, aiming to fix process startup issues by invoking analyzer commands through cmd /c with simplified argument quoting.
Changes:
- Route VS 2026+ analyzer launch through
cmd /c dnx ...instead of invokingdnxdirectly. - Simplify
cmd /c tsqlanalyze ...argument quoting for older VS versions to avoid malformed command lines.
Comment on lines
83
to
+85
| // Use dnx syntax for VS 2026 (version 18) or later | ||
| fileName = "dnx"; | ||
| args = "ErikEJ.DacFX.TSQLAnalyzer.Cli --yes -- -n -i" + | ||
| fileName = "cmd"; | ||
| args = "/c dnx ErikEJ.DacFX.TSQLAnalyzer.Cli --yes -- -n -i" + |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.