Conversation
|
Sorry, I messed up the previous PR. I tried my best to find a more legible output format. |
|
|
furtib
force-pushed
the
add-buildifier
branch
from
8405a74 to
9a6af27
Compare
furtib
force-pushed
the
add-buildifier
branch
4 times, most recently
from
3ab3a58 to
ebf8763
Compare
|
If it were to pass, this would be the most solid option. |
Bazel 8 specific warning will break bazel 6 compatibility
This reverts commit b526451.
| load("@buildifier_prebuilt//:rules.bzl", "buildifier_test") | ||
|
|
||
| buildifier_test( | ||
| name = "buildifier_native", |
There was a problem hiding this comment.
I wonder why it is named "_native"?
Any reasons for that?
| version = "6.4.0", | ||
| dev_dependency = True, | ||
| ) | ||
| bazel_dep(name = "aspect_rules_lint", version = "1.11.0", dev_dependency = True) |
There was a problem hiding this comment.
I think we do not need this. This is actually duplication of buildifier_prebuilt
| format_test( | ||
| name = "format_test", | ||
| # Temporary workaround for not being able to use -diff_command | ||
| env = ["BUILDIFIER_DIFF='diff -u'"], | ||
| no_sandbox = True, | ||
| # TODO: extend with pylint | ||
| starlark = "@buildifier_prebuilt//:buildifier", | ||
| starlark_check_args = [ | ||
| "-lint=warn", | ||
| "-warnings=all", | ||
| "-mode=diff", | ||
| # -u will always get passed to buildifier not diff_command | ||
| #"-diff_command=\"diff -u\"", | ||
| ], | ||
| workspace = "//:WORKSPACE", | ||
| ) |
|
|
||
| buildifier_test( | ||
| name = "buildifier_native", | ||
| diff_command = "diff -u", |
There was a problem hiding this comment.
May I ask why do we need this?
3 participants
Why:
We want to lint not just our Python but also our
.bzlfiles.What:
Addresses:
Buildifier #155