Repository navigation
fix(mlpot): gate CHARMM-path lattice virial behind its own experimental opt-in; log perf switches - #8
Merged
Conversation
…_CHARMM_LATTICE_VIRIAL (experimental); log active perf switches The CHARMM CPT wiring merged in #7 was never timed or validated, so KARML_ML_LATTICE_VIRIAL (JAX-MD path) no longer reaches it. md-system prints one line recording virial path, lattice virial, CHARMM-path switch and chunk remat. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ce-virial-and-log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hybrid_mlpot.forward_vir_fn), where it was never timed or validated (only JAX-MD was). That use now needs its own opt-inKARML_CHARMM_LATTICE_VIRIAL=1, which warns "EXPERIMENTAL and not validated";KARML_ML_LATTICE_VIRIALalone no longer touches CHARMM. Default path unchanged.md-systemprints oneperf switches:line (strain virial path, ML lattice virial, CHARMM-path switch, chunk remat) so reported runs record them.Tests
tests/unit/test_charmm_lattice_virial_gate.py(4) plustest_opt_in_defaults.py(3): 7 passed on CPU; ruff clean.🤖 Generated with Claude Code