Skip to content

docs(readme): add examples section with links to basic usage#586

Merged
Miou-zora merged 3 commits into
mainfrom
527-doc-add-a-link-to-examples-in-the-readme
Apr 21, 2026
Merged

docs(readme): add examples section with links to basic usage#586
Miou-zora merged 3 commits into
mainfrom
527-doc-add-a-link-to-examples-in-the-readme

Conversation

@Miou-zora
Copy link
Copy Markdown
Contributor

@Miou-zora Miou-zora commented Apr 18, 2026

Pull Request

Description

I added a link and an explanation on how to check examples and indicated where is an "hello world" looks like.

Related Issues (Put "None" if there are no related issues)

close #527

Type of Change

Please delete options that are not relevant.

  • Documentation update

Changes Made

List the main changes in this PR:

  • Added a link and an explanation on how to check examples
  • Indicated where is an "hello world" looks like

Testing

Describe the tests you ran to verify your changes. Please delete options that are not relevant.

None

Test Environment

  • OS: macOS
  • Compiler: Clang

Screenshots/Videos (Put "None" if there are no related issues)

None

Documentation

Please delete options that are not relevant.

  • I have updated the relevant documentation

Checklist (Don't delete any options)

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Breaking Changes (Put "None" if there are no related issues)

None

Additional Notes (Put "None" if there are no related issues)

None

Summary by CodeRabbit

  • Documentation
    • Updated links to Lights and Material example code to reflect new repository structure.
    • Added "Hello World" section with guidance on accessing basic examples across example folders.

@Miou-zora Miou-zora linked an issue Apr 18, 2026 that may be closed by this pull request
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 18, 2026

📝 Walkthrough

Walkthrough

Updated README.md to redirect example image links to new repository paths and added a "Hello World" section directing users to example folders across the codebase. Additionally, condensed error logging formatting in a CharacterControllerUsage example file without changing functionality.

Changes

Cohort / File(s) Summary
Documentation Updates
README.md
Updated image links for Lights and Material examples to point to new repository paths under src/plugin/default-pipeline/examples/. Added a new "Hello World" section with links to examples in examples/, src/engine/examples, and plugin directories, plus a hyperlink to BasicCoreUsage.
Code Formatting
examples/CharacterControllerUsage/src/main.cpp
Condensed multi-line error logging statement in destructor into a single-line fmt::format call without altering logging content or behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

documentation

Poem

🐰 Hoppy README improvements, we bound through with glee,
New links guide the travelers through examples with ease,
From hello to lights, the paths now align,
One log line condensed—oh, how documentation shines!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes a minor code formatting change in CharacterControllerUsage/src/main.cpp (condensing error logging) that is unrelated to the documentation objectives in issue #527. Remove or separate the code formatting change in main.cpp into a dedicated PR; keep this PR focused on README.md documentation changes only.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The PR title accurately reflects the main change: adding an Examples section to the README with links to basic usage examples.
Linked Issues check ✅ Passed The PR adds a 'Hello World' section to README.md with links to examples across multiple directories, directly addressing issue #527's requirement for a visible Examples section in the README to improve discoverability.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 527-doc-add-a-link-to-examples-in-the-readme

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Miou-zora Miou-zora self-assigned this Apr 18, 2026
@Miou-zora Miou-zora marked this pull request as ready for review April 18, 2026 10:09
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@README.md`:
- Around line 40-44: Edit the "Hello World" section header and sentence to fix
grammar and improve clarity: change "basics examples" to "basic examples",
replace the glob pattern "`**/examples`" with clearer wording such as "the
examples/ directory" (or "examples folder") and rephrase the awkward clause to
something like "For a simple 'Hello World' demonstration, see this example"
while keeping the existing link to the BasicCoreUsage example; update the full
sentence to read clearly and concisely.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7a213b1a-b632-478b-89dd-3143a9781e9a

📥 Commits

Reviewing files that changed from the base of the PR and between adabd83 and 1280ddd.

📒 Files selected for processing (1)
  • README.md

Comment thread README.md
@sonarqubecloud
Copy link
Copy Markdown

@Miou-zora
Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
README.md (1)

40-44: Consider simplifying the parenthetical for better clarity.

The parenthetical explanation on line 43 is a bit complex and could be clearer. The phrase "in root, src/engine/examples and examples folder in any plugin folder" packs multiple nested concepts into one clause, which may confuse readers.

Consider a clearer structure:

📝 Optional clarity improvement
-You can find basic examples in the `examples/` (in `root`, `src/engine/examples` and `examples` folder in any plugin folder in `src/plugin/`) folders throughout the project. For a "hello world" example, check [this one](https://github.com/EngineSquared/EngineSquared/tree/main/src/engine/examples/BasicCoreUsage).
+You can find basic examples throughout the project in several locations: `examples/` at the root, `src/engine/examples/`, and the `examples/` folder within any plugin under `src/plugin/`. For a "hello world" example, check [this one](https://github.com/EngineSquared/EngineSquared/tree/main/src/engine/examples/BasicCoreUsage).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@README.md` around lines 40 - 44, The parenthetical in the "Hello World"
section is confusing; rewrite it to list the example locations clearly and
separately. Replace the clause "in `root`, `src/engine/examples` and `examples`
folder in any plugin folder" with a clearer list such as: examples/ in the repo
root, src/engine/examples, and the examples/ folder inside each plugin
directory; keep the existing link to the BasicCoreUsage example unchanged.
Ensure the revised sentence appears under the "Hello World" heading and
preserves backticks around folder names.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@README.md`:
- Around line 40-44: The parenthetical in the "Hello World" section is
confusing; rewrite it to list the example locations clearly and separately.
Replace the clause "in `root`, `src/engine/examples` and `examples` folder in
any plugin folder" with a clearer list such as: examples/ in the repo root,
src/engine/examples, and the examples/ folder inside each plugin directory; keep
the existing link to the BasicCoreUsage example unchanged. Ensure the revised
sentence appears under the "Hello World" heading and preserves backticks around
folder names.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7af4ebc1-3c52-40ae-8862-386a4de72856

📥 Commits

Reviewing files that changed from the base of the PR and between 1280ddd and 8e83ee2.

📒 Files selected for processing (2)
  • README.md
  • examples/CharacterControllerUsage/src/main.cpp
✅ Files skipped from review due to trivial changes (1)
  • examples/CharacterControllerUsage/src/main.cpp

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{}

@Miou-zora Miou-zora merged commit 8ebbbb9 into main Apr 21, 2026
48 of 49 checks passed
@Miou-zora Miou-zora deleted the 527-doc-add-a-link-to-examples-in-the-readme branch April 21, 2026 08:31
Miou-zora added a commit that referenced this pull request May 24, 2026
# Pull Request

## Description

I added a link and an explanation on how to check examples and indicated
where is an "hello world" looks like.

## Related Issues (Put "None" if there are no related issues)

close #527

## Type of Change
Please delete options that are not relevant.

- Documentation update

## Changes Made
List the main changes in this PR:
- Added a link and an explanation on how to check examples
- Indicated where is an "hello world" looks like

## Testing
Describe the tests you ran to verify your changes. Please delete options
that are not relevant.

None

### Test Environment
- OS: macOS
- Compiler: Clang

## Screenshots/Videos (Put "None" if there are no related issues)

None

## Documentation
Please delete options that are not relevant.

- I have updated the relevant documentation

## Checklist (Don't delete any options)
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any dependent changes have been merged and published

## Breaking Changes (Put "None" if there are no related issues)

None

## Additional Notes (Put "None" if there are no related issues)

None


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Documentation**
* Updated links to Lights and Material example code to reflect new
repository structure.
* Added "Hello World" section with guidance on accessing basic examples
across example folders.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] Add a link to examples in the README

1 participant