Skip to content

Skip lookup of player names longer than 16 characters #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
intersecato wants to merge 1 commit into
base: version/7.0.x
Choose a base branch
from
Open

Skip lookup of player names longer than 16 characters #2328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions worldguard-core/src/main/java/com/sk89q/worldguard/protection/util/DomainInputResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
public class DomainInputResolver implements Callable<DefaultDomain> {

private static final Pattern GROUP_PATTERN = Pattern.compile("(?i)^[G]:(.+)$");
private static final int MAX_PLAYER_NAME_LENGTH = 16;

/**
* The policy for locating users.
Expand Down Expand Up @@ -119,9 +120,14 @@ public DefaultDomain call() throws UnresolvedNamesException {
}
}

if (!namesToQuery.isEmpty()) {
// Paper rejects longer names with an exception, so leave them unresolved.
List<String> validNames = namesToQuery.stream()
.filter(name -> name.length() <= MAX_PLAYER_NAME_LENGTH)
.toList();

if (!validNames.isEmpty()) {
try {
for (Profile profile : profileService.findAllByName(namesToQuery)) {
for (Profile profile : profileService.findAllByName(validNames)) {
namesToQuery.remove(profile.getName().toLowerCase());
domain.addPlayer(profile.getUniqueId());
}
Expand Down