[FIX] consistent seed in DL for ppo_pufferlib#459
Merged
daphne-cornelisse merged 1 commit intoJun 3, 2025
Merged
Conversation
Currently it is possible to unknowngly use two different seeds for the PPO and dataloader. Normally if everyone was using 42 for the seed there would be no effect, but we tested with varying seeds and had unintuitive results, so I think matching the seeds here makes sense.
daphne-cornelisse
approved these changes
Jun 3, 2025
Contributor
|
Thanks for catching this |
wangbingke0
pushed a commit
to wangbingke0/gpudrive
that referenced
this pull request
Feb 13, 2026
Currently it is possible to unknowngly use two different seeds for the PPO and dataloader. Normally if everyone was using 42 for the seed there would be no effect, but we tested with varying seeds and had unintuitive results, so I think matching the seeds here makes sense. Co-authored-by: Ellington Kirby <ellingtonkirby@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it is possible to unknowngly use two different seeds for the PPO and dataloader. Normally if everyone was using 42 for the seed there would be no effect, but we tested with varying seeds and had unintuitive results, so I think matching the seeds here makes sense.