Remove render mask and rescale#129
Merged
Merged
Conversation
aaravpandya
requested review from
SamanKazemkhani,
daphne-cornelisse and
eugenevinitsky
Contributor
|
I don't fully understand comment 2. I would think we do want to remove agents if they are not valid in the expert trajectory? |
Comment on lines
+78
to
+79
| adjusted_window_width = self.WINDOW_W/2 - self.padding_x | ||
| adjusted_window_height = self.WINDOW_H/2 - self.padding_y |
Contributor
There was a problem hiding this comment.
This here I don't understand why this showed up
eugenevinitsky
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs introduced - While the renders are correct, but there is a zoom out effect. Currently we scale by (w/2, h/2) so that the entire maps fits in. One can change it to (w, h) or (w/1.25, h/1.25) based on how zoomed in you want the render. However, the more you zoom in the more chances to lose maps on the edges.