Fix K-NN bugs#114
Merged
Merged
Conversation
aaravpandya
requested changes
May 13, 2024
aaravpandya
left a comment
aaravpandya
left a comment
Collaborator
There was a problem hiding this comment.
Can you also increase the consts::kMaxRoadEntityCount default value to 6000 ? That will allow the tests to pass.
| impl_->cfg.numWorlds, | ||
| consts::kMaxAgentCount, | ||
| consts::kMaxRoadEntityCount, | ||
| consts::kMaxAgentMapObservationsCount, |
Collaborator
There was a problem hiding this comment.
This will still fail for the AllEntitiesWithRadiusFiltering case. We need to add an IF condition here.
SamanKazemkhani
force-pushed
the
sk/fix-knn-bugs
branch
2 times, most recently
from
1821973 to
37498fd
Compare
SamanKazemkhani
requested review from
aaravpandya,
daphne-cornelisse and
eugenevinitsky
SamanKazemkhani
force-pushed
the
sk/fix-knn-bugs
branch
from
37498fd to
45b800b
Compare
aaravpandya
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.