Repository navigation
feat (Forever Essentials): gathering skill in node tooltips - #2692
Merged
EllesmereGaming merged 2 commits intoOct 17, 2026
Merged
Conversation
Jetro974
force-pushed
the
forever-gather-skill
branch
from
October 14, 2026 16:54
061aa2a to
f0d76f6
Compare
Jetro974
force-pushed
the
forever-gather-skill
branch
from
October 16, 2026 19:50
4e62112 to
6f93295
Compare
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Gathering Skill in Tooltips to Forever Essentials > General > Gathering (WoW Forever only, off by default). On a herb or ore node's tooltip, the game's own "Requires Herbalism / Requires Mining" line (just "Herbalism / Mining" once you have the skill) gains the skill the node needs. When you can gather the node, the line takes the colors recipes use for skill-ups: orange, yellow, green, grey; when you cannot, the game's red stays.
In its cog, Minimap (off by default) does the same on the minimap: a tracked herb or ore node's name in the mouseover tooltip is followed by its required skill in those colors ("Silverleaf (1)"), red when you cannot gather it. Other names in the same tooltip are left alone.
Seen in game: in combat, a node's own tooltip keeps the game's line until combat ends (text the game makes secret is skipped with
issecretvalue, never read or compared), while the minimap's mouseover names keep their skill.World object tooltips carry no object ID on Forever (the tooltip data's
guidandidare nil), so a node is recognized by its name:C_Item.GetItemNameByID), so every locale works with nothing to translate.Required skills are the game's Classic values (Wowhead). The few nodes WoW Forever added (Marefoil, Demonsage, Death Lotus, Heavy Thorium) keep the game's line until their skill is known: the client data has the skill tiers (
Lock) but not which node uses which.How was it tested?
WoW Forever client (French), in game: Silverleaf shows "Herboristerie (1)" in the skill-up color. The other paths (a node you cannot gather keeps the game's red, a node not in the table is left alone, the minimap's mouseover with several names, the option off) were run through the hooks with the client's tooltip data. The minimap path was also run through an offline harness with the game API stubbed: 60 redraws of the same tooltip parse it once, a herb whose item loads later is picked up, a skill-up recolors the line.
python3 .tools/guardrails.pypasses;_keys.txtis current; every locale file is valid UTF-8.Screenshots
Checklist
SKILL_LINES_CHANGEDregistered only while the minimap option is on). A herb whose item is not loaded yet is added on itsITEM_DATA_LOAD_RESULT, unregistered once none is missing. One table lookup per world object tooltip, a line rewritten only on a gathering nodeTooltipDataProcessor.AddTooltipPostCallonly; the line's text and color are set on the tooltip's own font string, as Simplified Stats does for item lines