Skip to content
This repository was archived by the owner on Jul 12, 2020. It is now read-only.

Add a new CRUD (and paging) Sample for .Net Core 2 - #31

Merged
Elfocrash merged 4 commits into
Elfocrash:developfrom
ntakouris:develop
Oct 3, 2018
Merged

Elfocrash merged 4 commits into
Elfocrash:developfrom
ntakouris:develop

Conversation

@ntakouris

Copy link
Copy Markdown
Contributor

Also add 2 entities that are not in a Shared Collection on the simpler Console sample

.
Happy Hacktoberfest!

@Elfocrash Elfocrash left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Just a few comments. Also can you please make sure that functionality wise it is fully tested? The sample code should be working with absolutely no issues when someone is running it.

Comment thread samples/Cosmonaut.Console/EntityWithoutPropertyWithIdName.cs Outdated
Comment thread samples/Cosmonaut.NetCore2WebApi/Controllers/SampleController.cs Outdated
Comment thread samples/Cosmonaut.NetCore2WebApi/Controllers/SampleController.cs Outdated
Comment thread samples/Cosmonaut.NetCore2WebApi/Controllers/SampleController.cs Outdated
Comment thread samples/Cosmonaut.NetCore2WebApi/Controllers/SampleController.cs Outdated
Comment thread samples/Cosmonaut.NetCore2WebApi/Controllers/SampleController.cs Outdated
@ntakouris

Copy link
Copy Markdown
Contributor Author

Changes were posted.

Everything works, tested with Postman & Cosmos DB Emulator

@Elfocrash
Elfocrash merged commit bb70bb0 into Elfocrash:develop Oct 3, 2018
@Elfocrash

Copy link
Copy Markdown
Owner

Good stuff, thank you! Merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants