Skip to content

Fix single instance broken #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidroth wants to merge 1 commit into from
Closed

Fix single instance broken #994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ElectronNET.API/Runtime/StartupManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,11 @@ private BuildInfo GatherBuildInfo()

if (isSingleInstance?.Length > 0 && bool.TryParse(isSingleInstance, out var isSingleInstanceActive) && isSingleInstanceActive)
{
buildInfo.ElectronSingleInstance = "yes";
buildInfo.ElectronSingleInstance = "true";
Comment thread
davidroth marked this conversation as resolved.
}
else
{
buildInfo.ElectronSingleInstance = "no";
buildInfo.ElectronSingleInstance = "false";
}

if (httpPort?.Length > 0 && int.TryParse(httpPort, out var port))
Expand Down
2 changes: 1 addition & 1 deletion src/ElectronNET.Host/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ app.on('will-finish-launching', () => {

const manifestJsonFile = require(manifestJsonFilePath);

if (manifestJsonFile.singleInstance === "yes") {
if (manifestJsonFile.singleInstance === "true" || manifestJsonFile.singleInstance === "True") {
Comment thread
davidroth marked this conversation as resolved.
const mainInstance = app.requestSingleInstanceLock();
app.on('second-instance', (events, args = []) => {
args.forEach((parameter) => {
Expand Down
Loading