Repository navigation
fix: resolve schemas through generic agent subclasses - #328
Merged
Eigenwise merged 1 commit intoOct 24, 2026
Merged
Conversation
Eigenwise
approved these changes
Oct 24, 2026
Eigenwise
left a comment
Owner
There was a problem hiding this comment.
Rechecked a800ffa. All twelve native generic-schema tests pass locally. Independent offline probes covered intermediate and reordered generic bindings, specialization independence, public schema overrides, and the hook-lifecycle change. No public-API blocker found. Exact-head CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully specializing a reusable
AtomicAgentsubclass can leave aTypeVarininput_schemaoroutput_schema, causingrun()to fail before sending a completion request. Resolve the concrete bindings along the instance's specialized bases instead of caching raw type parameters on the class. Direct agents, concrete subclasses and untyped defaults keep their behavior, and different specializations keep independent bindings.This extends the concrete-subclass handling in #187 to generic intermediate classes.
Validation:
Prepared with AI assistance.