Skip to content

fix: resolve schemas through generic agent subclasses - #328

Merged
Eigenwise merged 1 commit into
Eigenwise:mainfrom
March-7:codex/round152-generic-agent-schemas
Oct 24, 2026
Merged

Eigenwise merged 1 commit into
Eigenwise:mainfrom
March-7:codex/round152-generic-agent-schemas

Conversation

@March-7

@March-7 March-7 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Fully specializing a reusable AtomicAgent subclass can leave a TypeVar in input_schema or output_schema, causing run() to fail before sending a completion request. Resolve the concrete bindings along the instance's specialized bases instead of caching raw type parameters on the class. Direct agents, concrete subclasses and untyped defaults keep their behavior, and different specializations keep independent bindings.

This extends the concrete-subclass handling in #187 to generic intermediate classes.

Validation:

  • New native regressions: 7 failed / 5 passed on the base; the same test bytes pass all 12 cases with the fix.
  • Independent local HTTP probe: 8/8 cases pass, including reordered parameters, forwarded templates and two output specializations.
  • Core suite: 818 passed, 3 live MiniMax tests skipped.
  • Repository Black and Flake8 checks pass; the configured Pyright check reports 0 errors. An additional direct source scan reports 18 existing diagnostics versus 21 on the base, with none added.

Prepared with AI assistance.

@Eigenwise Eigenwise left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rechecked a800ffa. All twelve native generic-schema tests pass locally. Independent offline probes covered intermediate and reordered generic bindings, specialization independence, public schema overrides, and the hook-lifecycle change. No public-API blocker found. Exact-head CI is green.

@Eigenwise
Eigenwise merged commit ea7c09a into Eigenwise:main Oct 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants