Repository navigation
Conversation
MCP registration extracted handler services from the tool record instead of its values, so declared dependencies such as HttpClient disappeared from the required context. Retain those requirements so incomplete server dependency graphs fail at compile time.
🦋 Changeset detectedLatest commit: ccd9bc8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
brandon-julio-t
marked this pull request as ready for review
October 6, 2026 05:37
tim-smart
enabled auto-merge (squash)
October 6, 2026 07:20
brandon-julio-t
added a commit
to brandon-julio-t/brandon-julio-t
that referenced
this pull request
Oct 6, 2026
Effect PR #8842 is merged and closes issue #8843. Record the diagnosis, bug report, and upstream fix so profile readers can assess this contribution through its original evidence. Effect-TS/effect#8842
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix MCP toolkit registration losing tool handler and schema service requirements. Incomplete servers could previously compile and fail with errors such as
Service not found: effect/HttpClient.registerToolkitandtoolkitnow applyTool.HandlerServicestoTools[keyof Tools]rather than the tool record. The captured context tracks those requirements; runtime behavior is unchanged.Focused type regressions cover dependencies from multiple tools, parameter decoding, success and failure encoding, and both registration APIs. Registration still excludes the per-call
McpRequestContextand requiresMcpServerClient. Includes aneffectpatch changeset.Validation
pnpm checkpasses; MCP runtime tests pass (98 tests).1b092387c5found no actionable findings.pnpm lint-fixandgit diff --checkpass. Source and tests are unchanged from the reviewed commit.All toolchain validation used
nix develop -c.Takeover checklist
Closes #8843
Closes EFF-1785
Related: #8526 covers decoder service requirements in
Toolkit.handle.