Repository navigation
Make RPC socket ping timing configurable and count all server frames as liveness - #8825
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 3bfc949 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
pingIntervalandpingTimeoutto RPC socket clients, with the existing 5-second defaults. Track the last decoded server frame usingClock, so non-pong traffic keeps a connection alive. ForwardretryPolicythroughlayerProtocolSocketand document the timing semantics. Includes aneffectpatch changeset and the tests-only handoff commit.Validation
RpcClient.test.ts: all 17 tests pass, including the existing default missed-pong test.pnpm lint-fix,pnpm lint, andpnpm jsdocs --check: pass (all run throughnix develop -c).pnpm check: fails atpackages/effect/test/rpc/RpcClient.test.ts:490. The tests-only commit stores the options in an unannotated mutable object, widening"2 seconds"and"15 seconds"tostring, which is notDuration.Input. The test needs literal preservation (for example,as const) in a separate correction run. Tests were left unchanged as requested.Closes #8774
Closes EFF-1707