feat: 로그인 / 회원가입 UI 구현#10
Merged
Merged
Conversation
Contributor
|
지금처럼 010만 고려해도 괜찮은것 같아요! SignupDialog.tsx에서 terms/privacy/marketing의 <Checkbox.... /> 에 cursor-pointer 추가하면 좋을것같아요 그리고 SignupDialog.tsx 맨 아래에 로그인 버튼이랑, LoginDialog.tsx 맨 아래에 회원가입 버튼에 조금더 bold 처리를 주고, 밝은 회색 백경으로 hover 됐을때 더 잘 보여주면 좋을것같습니다 회원가입이랑 로그인 둘다 우상단에 있는 닫기표시 X버튼이 조금더 크고 hover시에 더 잘보였으면 좋겠어요! 저는 react의 X아이콘을 사용해서 효과를 바꿔주었는데, 듀님은 DialogContent 내부에 기본 랜더링되어있는 DialogPrimitive.Close를 사용하신거라, src/components/ui/dialog.tsx 안에서 DialogContent 내부에 DialogPrimitive.Close 클래스에서 효과 추가해주시면 될것같아요! |
Contributor
Author
1.mp4 |
jjjsun
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 개요
🔢 관련 이슈 링크
💻 작업내용
📌 변경사항PR
🤔 추가 논의하고 싶은 내용
현재 휴대폰 번호 validation을 010xxxxxxxx 형식으로 제한했는데
외국인/해외 번호도 고려해야할까요?
✅ 체크리스트